Re: [PATCH FOR-4.5] xen: arm: Do not enable EFI in dom0 since it is not yet supported.

[Julien Grall <julien.grall@linaro.org>]

Hi Ian,

On 10/14/2014 08:21 AM, Ian Campbell wrote:
> On Mon, 2014-10-13 at 12:37 -0700, Roy Franz wrote:
>> On Mon, Oct 13, 2014 at 9:20 AM, Julien Grall <julien.grall@linaro.org> wrote:
>>> (CC vijay)
>>>
>>> Hi Suravee,
>>>
>>> On 10/13/2014 05:17 PM, suravee.suthikulpanit@amd.com wrote:
>>>> From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
>>>>
>>>> Since EFI is not yet supported in dom0, we need to remove the following
>>>> properties from the chosen node:
>>>>
>>>>   * linux,uefi-mmap-start
>>>>   * linux,uefi-mmap-size
>>>>   * linux,uefi-mmap-desc-size
>>>>   * linux,uefi-mmap-desc-ver
>>>>
>>>> These are added by "arch/arm/efi/efi-boot.h: fdt_add_uefi_nodes()",
>>>> and used by dom0 kernel to enable EFI.
>>>>
>>>> Cc: Julien Grall <julien.grall@linaro.org>
>>>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>>>> Cc: Ian Campbell <ian.campbell@citrix.com>
>>>> Cc: Roy Franz <roy.franz@linaro.org>
>>>> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>>>
>>> Reviewed-by: Julien Grall <julien.grall@linaro.org>
>>
>> Reviewed-by: Roy Franz <roy.franz@linaro.org>
> 
> Acked-by: Ian Campbell <ian.campbell@.citrix.com>
> 
> But I do wonder why we don't just drop the hos /chosen node -- I think
> everything which should be in there is fabricated by the h/visor anyway.

I though about the same things yesterday, but the /chosen node may
contain other properties (such as OS specific) that we may need to pass
to DOM0.

So a blacklist looks the better solution for now.

Regards,

-- 
Julien Grall