All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gst1-plugins-imx: add package
Date: Tue, 14 Oct 2014 16:31:59 +0200	[thread overview]
Message-ID: <543D33DF.8070005@mind.be> (raw)
In-Reply-To: <543BC031.60606@lucaceresoli.net>

On 13/10/14 14:06, Luca Ceresoli wrote:
> Dear Gary,
> 
> Gary Bisson wrote:
>> Hi Luca,
>>
>> Thanks for your feedback, below are my comments.
>> Sorry Peter I didn't see your patch from March.
>>
>> On 10/12/2014 07:43 AM, Luca Ceresoli wrote:
[snip]
>>> According to Gary, (e)glibc is needed. Peter, did you build-test with
>>> uClibc (or musl)?
>> Actually this dependency is not required as it is implicit, the real
>> eglibc dependency comes from the GPU_VIV package.
> 
> I see. A brief comment would be helpful, as it is for all inherited
> dependencies. Example:
> 
> # Required by gpu-viv-bin-mx6q
> comment "gst1-plugins-imx needs an (e)glibc toolchain"
>     depends on BR2_arm
>     depends on !BR2_TOOLCHAIN_USES_GLIBC

 That's not the right place for pointing to gpu-viv-bin-mx6q. It should be
something like:

config BR2_PACKAGE_GST1_PLUGINS_IMX
	bool "gst1-plugins-imx"
	depends on BR2_LINUX_KERNEL
	depends on BR2_arm # Only relevant for i.MX
	depends on BR2_TOOLCHAIN_USES_GLIBC # gpu-viv-bin-mx6q
	select BR2_PACKAGE_GPU_VIV_BIN_MX6Q
	# Cannot select libfslvpuwrap because user must select the CPU
	depends on BR2_PACKAGE_LIBFSLVPUWRAP

(I added that thing about libfslvpuwrap but I'm not sure of it...)


 Regards,
 Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2014-10-14 14:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-05 21:47 [Buildroot] [PATCH] gst1-plugins-imx: add package Gary Bisson
2014-10-12 14:43 ` Luca Ceresoli
2014-10-13  4:18   ` Gary Bisson
2014-10-13 12:06     ` Luca Ceresoli
2014-10-14 14:31       ` Arnout Vandecappelle [this message]
2014-10-14 17:16         ` Gary Bisson
2014-10-14 21:05           ` Arnout Vandecappelle
2014-10-17 21:07             ` Yann E. MORIN
2014-10-17 21:28               ` Gary Bisson
2014-10-17 21:39                 ` Yann E. MORIN
2014-10-28 15:02                   ` Luca Ceresoli
  -- strict thread matches above, loose matches on Subject: below --
2014-10-13 22:05 Peter Seiderer
2014-10-14  7:16 ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=543D33DF.8070005@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.