From mboxrd@z Thu Jan 1 00:00:00 1970 From: Georgi Djakov Subject: Re: [PATCH v2 3/3] ARM: dts: qcom: Add SDHC nodes for APQ8084 platform Date: Tue, 14 Oct 2014 19:17:11 +0300 Message-ID: <543D4C87.9050703@mm-sol.com> References: <1409672443-4289-1-git-send-email-gdjakov@mm-sol.com> <1409672443-4289-4-git-send-email-gdjakov@mm-sol.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Bjorn Andersson Cc: Kumar Gala , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Russell King , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-arm-msm , "Ivan T. Ivanov" List-Id: linux-arm-msm@vger.kernel.org On 10/10/2014 08:14 PM, Bjorn Andersson wrote: > On Tue, Sep 2, 2014 at 8:40 AM, Georgi Djakov wrote: >> Enable support for the two SD host controllers on the APQ8084 platform >> by adding the required nodes to the DT files. >> On the IFC6540 board, the first controller is connected to the onboard >> eMMC and the second is connected to a micro-SD card slot. >> >> Signed-off-by: Georgi Djakov > > Hi Georgi, > > This looks sane, but... > >> --- >> arch/arm/boot/dts/qcom-apq8084-ifc6540.dts | 11 +++++++++++ >> arch/arm/boot/dts/qcom-apq8084.dtsi | 23 +++++++++++++++++++++++ >> 2 files changed, 34 insertions(+) >> >> diff --git a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts >> index e41cb8a..c9ff108 100644 >> --- a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts >> +++ b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts > [..] >> + sdhci@f98a4900 { >> + cd-gpios = <&tlmm 122 GPIO_ACTIVE_LOW>; >> + bus-width = <4>; > > ...why do you add this node and leave it disabled in the dts? > Hi Bjorn, Currently only the eMMC is functional on this board, so now we have just the board specific configuration under this node. More patches are forthcoming. BR, Georgi From mboxrd@z Thu Jan 1 00:00:00 1970 From: gdjakov@mm-sol.com (Georgi Djakov) Date: Tue, 14 Oct 2014 19:17:11 +0300 Subject: [PATCH v2 3/3] ARM: dts: qcom: Add SDHC nodes for APQ8084 platform In-Reply-To: References: <1409672443-4289-1-git-send-email-gdjakov@mm-sol.com> <1409672443-4289-4-git-send-email-gdjakov@mm-sol.com> Message-ID: <543D4C87.9050703@mm-sol.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/10/2014 08:14 PM, Bjorn Andersson wrote: > On Tue, Sep 2, 2014 at 8:40 AM, Georgi Djakov wrote: >> Enable support for the two SD host controllers on the APQ8084 platform >> by adding the required nodes to the DT files. >> On the IFC6540 board, the first controller is connected to the onboard >> eMMC and the second is connected to a micro-SD card slot. >> >> Signed-off-by: Georgi Djakov > > Hi Georgi, > > This looks sane, but... > >> --- >> arch/arm/boot/dts/qcom-apq8084-ifc6540.dts | 11 +++++++++++ >> arch/arm/boot/dts/qcom-apq8084.dtsi | 23 +++++++++++++++++++++++ >> 2 files changed, 34 insertions(+) >> >> diff --git a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts >> index e41cb8a..c9ff108 100644 >> --- a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts >> +++ b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts > [..] >> + sdhci at f98a4900 { >> + cd-gpios = <&tlmm 122 GPIO_ACTIVE_LOW>; >> + bus-width = <4>; > > ...why do you add this node and leave it disabled in the dts? > Hi Bjorn, Currently only the eMMC is functional on this board, so now we have just the board specific configuration under this node. More patches are forthcoming. BR, Georgi