From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 for 4.5] arm32: fix build after 063188f4b3 Date: Tue, 14 Oct 2014 17:31:23 +0100 Message-ID: <543D4FDB.2080003@linaro.org> References: <1413301941-31853-1-git-send-email-julien.grall@linaro.org> <543D6B84020000780003ED55@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Xe50V-0004ZR-JC for xen-devel@lists.xenproject.org; Tue, 14 Oct 2014 16:31:31 +0000 Received: by mail-wi0-f179.google.com with SMTP id d1so10770054wiv.0 for ; Tue, 14 Oct 2014 09:31:30 -0700 (PDT) In-Reply-To: <543D6B84020000780003ED55@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On 10/14/2014 05:29 PM, Jan Beulich wrote: >>>> On 14.10.14 at 17:52, wrote: >> "xen: arm: Add support for the Exynos secure firmware" introduced code >> assuming that exynos_smc() would get called with arguments in certain >> registers. While the "noinline" attribute guarantees the function to >> not get inlined, it does not guarantee that all arguments arrive in the >> assumed registers: gcc's interprocedural analysis can result in clone >> functions to be created where some of the incoming arguments (commonly >> when they have constant values) get replaced by putting in place the >> respective values inside the clone. >> >> Xen contains in multiple place of this SMC function: consolidate the >> function >> in a single place and write it in assembly. >> >> Signed-off-by: Julien Grall >> Signed-off-by: Jan Beulich >> >> --- >> This is a fix for Xen 4.5 to compile the hypervisor with GCC 4.9.1, used by >> Fedora & co. >> >> Jan: I kept your Signed-off-by for the commit message. >> >> Changes in v2: >> - Write the SMC call in assembly >> - Consolidate the code in a single place > > To me it very much looks like (not just because of the subject) you > sent v2 again, rather than v3. Oh right. I will send the v3 in a couple of minutes. Regards, -- Julien Grall