From: Prarit Bhargava <prarit@redhat.com>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: herbert@gondor.apana.org.au, bruce.w.allan@intel.com,
qat-linux@intel.com, naleksan@redhat.com,
linux-crypto@vger.kernel.org, davem@davemloft.net,
Larry Woodman <lwoodman@redhat.com>
Subject: Re: [PATCH v2 2/2] crypto: qat - Enforce valid numa configuration
Date: Tue, 14 Oct 2014 13:27:27 -0400 [thread overview]
Message-ID: <543D5CFF.20804@redhat.com> (raw)
In-Reply-To: <543D5AD4.1090809@intel.com>
On 10/14/2014 01:18 PM, Tadeusz Struk wrote:
> On 10/14/2014 08:41 AM, Prarit Bhargava wrote:
>> Oh, that's a really good point. But can you at least change the message to do a
>> FW_BUG and dump the node information? That would be useful for debugging.
>
> But this not always will be a FW_BUG. If a user will not populate one of
> the nodes with memory this will happen as well.
Hmmm ... let's maybe think about this. I wonder if there is some mechanism with
which we can determine that? Larry Woodman -- is there any mm related call that
we can make to determine if a node is memory-less?
I could see this to be
> the main reason of this message to be printed. In this case
> num_possible_nodes() will be e.g. 2 and dev_to_node(&pdev->dev) will be
> -1 so I don't really know what will be a useful info to print so we
> don't confuse the user.
If you see -1, it means "No node was assigned" ... so -1 in a debug message is
okay IMO.
P.
> T
>
next prev parent reply other threads:[~2014-10-14 17:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 1:24 [PATCH v2 0/2] crypto: qat - Fix for invalid dma mapping and numa Tadeusz Struk
2014-10-14 1:24 ` [PATCH v2 1/2] crypto: qat - Prevent dma mapping zero length assoc data Tadeusz Struk
2014-10-14 1:24 ` [PATCH v2 2/2] crypto: qat - Enforce valid numa configuration Tadeusz Struk
2014-10-14 10:53 ` Prarit Bhargava
2014-10-14 14:50 ` Tadeusz Struk
2014-10-14 15:41 ` Prarit Bhargava
2014-10-14 17:18 ` Tadeusz Struk
2014-10-14 17:27 ` Prarit Bhargava [this message]
2014-10-14 17:32 ` Prarit Bhargava
2014-10-15 10:35 ` [PATCH v2 0/2] crypto: qat - Fix for invalid dma mapping and numa Nikolay Aleksandrov
2014-10-15 11:25 ` Prarit Bhargava
2014-10-15 16:24 ` Tadeusz Struk
2014-10-24 14:45 ` Herbert Xu
2014-11-17 15:43 ` Tadeusz Struk
2014-11-17 16:59 ` Greg KH
2014-11-17 17:20 ` Tadeusz Struk
2014-11-17 18:33 ` Greg KH
2014-12-05 18:34 ` Tadeusz Struk
2014-12-06 6:45 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543D5CFF.20804@redhat.com \
--to=prarit@redhat.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=lwoodman@redhat.com \
--cc=naleksan@redhat.com \
--cc=qat-linux@intel.com \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.