From: Corey Minyard <minyard@acm.org>
To: trenn@suse.de
Cc: linux-kernel@vger.kernel.org, openipmi-developer@lists.sourceforge.net
Subject: Re: [patch 3/3] ipmi: Unregister previously registered driver in error case
Date: Tue, 14 Oct 2014 20:27:34 -0500 [thread overview]
Message-ID: <543DCD86.30803@acm.org> (raw)
In-Reply-To: <20141014144315.728965695@d46.suse.de>
Queued, thanks for spotting this.
-corey
On 10/14/2014 09:40 AM, trenn@suse.de wrote:
Signed-off-by: Thomas Renninger <trenn@suse.de>
CC: minyard@acm.org
Index: kernel_ipmi/drivers/char/ipmi/ipmi_msghandler.c
===================================================================
--- kernel_ipmi.orig/drivers/char/ipmi/ipmi_msghandler.c
+++ kernel_ipmi/drivers/char/ipmi/ipmi_msghandler.c
@@ -4545,6 +4545,7 @@ static int ipmi_init_msghandler(void)
proc_ipmi_root = proc_mkdir("ipmi", NULL);
if (!proc_ipmi_root) {
printk(KERN_ERR PFX "Unable to create IPMI proc dir");
+ driver_unregister(&ipmidriver.driver);
return -ENOMEM;
}
prev parent reply other threads:[~2014-10-15 1:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20141014144020.683892494@d46.suse.de>
[not found] ` <20141014144315.178850163@d46.suse.de>
2014-10-15 1:22 ` [patch 1/3] ipmi: Setup ipmi_devintf automatically if ipmi_msghandler gets loaded Corey Minyard
2014-10-17 7:49 ` Thomas Renninger
2014-10-17 16:14 ` Corey Minyard
2014-10-20 8:28 ` Wilck, Martin
2014-10-23 9:56 ` Thomas Renninger
2014-10-24 10:40 ` Wilck, Martin
2014-10-28 12:10 ` Thomas Renninger
[not found] ` <20141014144315.519093022@d46.suse.de>
2014-10-15 1:26 ` [patch 2/3] ipmi: Remove ipmi_major module parameter and define global IPMI_MAJOR Corey Minyard
2014-10-17 7:55 ` Thomas Renninger
2014-10-17 16:21 ` Corey Minyard
[not found] ` <20141014144315.728965695@d46.suse.de>
2014-10-15 1:27 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543DCD86.30803@acm.org \
--to=minyard@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.