Re: [PATCH] Input: misc: max77693-haptic - fix active state check in disable()

[Jaewon Kim <jaewon02.kim@samsung.com>]

Hi Chanwoo,


2014년 10월 15일 13:17에 Chanwoo Choi 이(가) 쓴 글:
> Hi Jaewon,
>
> I think you better to use ':' instead of '-'.
> - before: Input: misc: max77693-haptic -
> - after : Input: misc: max77693-haptic:
I refer past log message.
I think '-' is input driver style.

>
> On 10/15/2014 12:16 PM, Jaewon Kim wrote:
>> In order to avoid duplicated execution, max77693_haptic_disable()
>> check disable state. But it was reversed. this patch fix it.
>>
>> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
>> ---
>>   drivers/input/misc/max77693-haptic.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/input/misc/max77693-haptic.c b/drivers/input/misc/max77693-haptic.c
>> index d605db4..7b1fde9 100644
>> --- a/drivers/input/misc/max77693-haptic.c
>> +++ b/drivers/input/misc/max77693-haptic.c
>> @@ -152,7 +152,7 @@ static void max77693_haptic_disable(struct max77693_haptic *haptic)
>>   {
>>   	int error;
>>   
>> -	if (haptic->enabled)
>> +	if (!haptic->enabled)
>>   		return;
>>   
>>   	error = max77693_haptic_configure(haptic, false);
>>
> If you modify patch name, Looks good to me.
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>
> Thanks,
> Chanwoo Choi
>

Thanks,
Jaewon Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html