From: Edward Cree <ecree@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: <dborkman@redhat.com>, <nikolay@redhat.com>,
<netdev@vger.kernel.org>, <sshah@solarflare.com>,
<jcooper@solarflare.com>, <linux-net-drivers@solarflare.com>
Subject: Re: [PATCH RFC net-next] sfc: add support for skb->xmit_more
Date: Wed, 15 Oct 2014 12:05:35 +0100 [thread overview]
Message-ID: <543E54FF.1040304@solarflare.com> (raw)
In-Reply-To: <20141014.171501.448630399243434370.davem@davemloft.net>
On 14/10/14 22:15, David Miller wrote:
> From: Edward Cree <ecree@solarflare.com>
> Date: Tue, 14 Oct 2014 19:41:37 +0100
>
>> Don't ring the doorbell, and don't do PIO. This will also prevent
>> TX Push, because there will be more than one buffer waiting when
>> the doorbell is rung.
>>
>> Signed-off-by: Edward Cree <ecree@solarflare.com>
> This looks good to me, mind if I apply this now?
I'd rather wait until Jon Cooper's had a chance to look at it; he
understands our TX path better than I.
-Edward
next prev parent reply other threads:[~2014-10-15 11:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 16:59 [PATCH] sfc: efx: add support for skb->xmit_more Daniel Borkmann
2014-10-13 18:02 ` Edward Cree
2014-10-13 19:18 ` Daniel Borkmann
2014-10-14 18:41 ` [PATCH RFC net-next] sfc: " Edward Cree
2014-10-14 21:15 ` David Miller
2014-10-15 11:05 ` Edward Cree [this message]
2014-10-15 16:20 ` David Miller
2014-10-16 15:42 ` Jonathan Cooper
2014-10-16 16:36 ` Robert Stonehouse
2014-10-17 14:32 ` [PATCH " Edward Cree
2014-10-18 3:47 ` David Miller
2014-10-22 8:58 ` Ben Hutchings
2014-10-22 12:36 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543E54FF.1040304@solarflare.com \
--to=ecree@solarflare.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=jcooper@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=sshah@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.