From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 for 4.5] arm32: fix build after 063188f4b3 Date: Wed, 15 Oct 2014 14:14:05 +0100 Message-ID: <543E731D.7070605@linaro.org> References: <1413304323-4639-1-git-send-email-julien.grall@linaro.org> <1413360689.10417.80.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XeOP8-0000S7-FI for xen-devel@lists.xenproject.org; Wed, 15 Oct 2014 13:14:14 +0000 Received: by mail-wi0-f179.google.com with SMTP id d1so1866947wiv.6 for ; Wed, 15 Oct 2014 06:14:13 -0700 (PDT) In-Reply-To: <1413360689.10417.80.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, Jan Beulich , stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 10/15/2014 09:11 AM, Ian Campbell wrote: > On Tue, 2014-10-14 at 17:32 +0100, Julien Grall wrote: >> @@ -263,7 +250,7 @@ static int exynos5_cpu_up(int cpu) >> iounmap(power); >> >> if ( secure_firmware ) >> - exynos_smc(SMC_CMD_CPU1BOOT, cpu, 0, 0); >> + call_smc1(SMC_CMD_CPU1BOOT, cpu); >> > > Have you confirmed that none of these zeroes (throughout the patch, not > just here) are actually unused and not just formal parameters which > happen to be zero. I can't find any documentation the exynos SMC call on the web. I will send a new version by removing call_smc and always use call_smc with 4 parameters. >> +#elif defined(CONFIG_ARM_64) >> +/* Not specific ARM64 macros for now */ > > "No specific..." Ok. >> + >> +int do_smc(register_t function_id, ...); > > Stray? Yes. -- Julien Grall