From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH v2] target-ppc: kvm: Fix memory overflow issue about strncat() Date: Wed, 15 Oct 2014 15:52:41 +0200 Message-ID: <543E7C29.2030507@suse.de> References: <543E7B17.1050902@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: qemu-ppc@nongnu.org, kvm@vger.kernel.org, qemu-devel To: Chen Gang , Paolo Bonzini Return-path: Received: from cantor2.suse.de ([195.135.220.15]:52960 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbaJONwn (ORCPT ); Wed, 15 Oct 2014 09:52:43 -0400 In-Reply-To: <543E7B17.1050902@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 15.10.14 15:48, Chen Gang wrote: > strncat() will append additional '\0' to destination buffer, so need > additional 1 byte for it, or may cause memory overflow, just like other > area within QEMU have done. > > And can use g_strdup_printf() instead of strncat(), which may be more > easier understanding. > > Signed-off-by: Chen Gang Thanks, applied to ppc-next. And sorry for not replying earlier. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeP0U-0003TZ-Tr for qemu-devel@nongnu.org; Wed, 15 Oct 2014 09:52:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XeP0M-0008OQ-MB for qemu-devel@nongnu.org; Wed, 15 Oct 2014 09:52:50 -0400 Message-ID: <543E7C29.2030507@suse.de> Date: Wed, 15 Oct 2014 15:52:41 +0200 From: Alexander Graf MIME-Version: 1.0 References: <543E7B17.1050902@gmail.com> In-Reply-To: <543E7B17.1050902@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] target-ppc: kvm: Fix memory overflow issue about strncat() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Gang , Paolo Bonzini Cc: qemu-ppc@nongnu.org, qemu-devel , kvm@vger.kernel.org On 15.10.14 15:48, Chen Gang wrote: > strncat() will append additional '\0' to destination buffer, so need > additional 1 byte for it, or may cause memory overflow, just like other > area within QEMU have done. > > And can use g_strdup_printf() instead of strncat(), which may be more > easier understanding. > > Signed-off-by: Chen Gang Thanks, applied to ppc-next. And sorry for not replying earlier. Alex