From: David Vrabel <david.vrabel@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
Cc: boris.ostrovsky@oracle.com, david.vrabel@citrix.com,
ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH RFC 00/10] Xen balloon page compaction support
Date: Wed, 15 Oct 2014 17:25:41 +0100 [thread overview]
Message-ID: <543EA005.3090407@citrix.com> (raw)
In-Reply-To: <1413388459-4663-1-git-send-email-wei.liu2@citrix.com>
On 15/10/14 16:54, Wei Liu wrote:
> Hi all
>
> This is a prototype to make Xen balloon driver work with balloon page
> compaction. The goal is to reduce guest physical address space fragmentation
> introduced by balloon pages. Having guest physical address space as contiguous
> as possible is generally useful (because guest can have higher order pages), and
> it should also help improve HVM performance (provided that guest kernel knows
> how to use huge pages -- Linux has hugetlbfs and transparent huge page).
>
> The approach is simple. Core balloon driver is made one of the page sources of
> Xen balloon driver. Those pages allocated from core balloon driver are subject
> to balloon page compaction.
Your page migrate function is broken. I'm not going to review anything
else in this series until you propose a solution for this.
David
next prev parent reply other threads:[~2014-10-15 16:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 15:54 [PATCH RFC 00/10] Xen balloon page compaction support Wei Liu
2014-10-15 15:54 ` [PATCH RFC 01/10] balloon_compaction: don't BUG() when it is not necessary Wei Liu
2014-10-15 15:54 ` [PATCH RFC 02/10] xen/balloon: fix code comment for free_xenballooned_pages Wei Liu
2014-10-15 15:54 ` [PATCH RFC 03/10] xen/balloon: consolidate data structures Wei Liu
2014-10-15 15:54 ` [PATCH RFC 04/10] xen/balloon: factor out function to update balloon stats Wei Liu
2014-10-15 15:54 ` [PATCH RFC 05/10] xen/balloon: rework increase_reservation Wei Liu
2014-10-15 15:54 ` [PATCH RFC 06/10] xen/balloon: make use of generic balloon driver Wei Liu
2014-10-15 15:54 ` [PATCH RFC 07/10] xen/balloon: factor out some helper functions Wei Liu
2014-10-15 15:54 ` [PATCH RFC 08/10] xen/balloon: implement migratepage Wei Liu
2014-10-15 16:16 ` David Vrabel
2014-10-16 9:28 ` Ian Campbell
2014-10-15 15:54 ` [PATCH RFC 09/10] balloon: BALLOON_COMPACTION now depends on XEN_BALLOON Wei Liu
2014-10-15 15:54 ` [PATCH RFC 10/10] XXX: balloon bitmap and sysrq key to dump bitmap Wei Liu
2014-10-15 16:25 ` David Vrabel [this message]
2014-10-15 16:30 ` [PATCH RFC 00/10] Xen balloon page compaction support Wei Liu
2014-10-16 9:31 ` David Vrabel
2014-10-15 16:54 ` Andrew Cooper
2014-10-15 17:00 ` Wei Liu
2014-10-15 17:14 ` Andrew Cooper
2014-10-16 9:12 ` Wei Liu
2014-10-16 9:26 ` Ian Campbell
2014-10-17 12:35 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543EA005.3090407@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.