From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
To: <dsterba@suse.cz>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Chris Mason <clm@fb.com>, Filipe Manana <fdmanana@suse.com>
Cc: naota <naota@elisp.net>
Subject: Re: [PATCH 1/4] btrfs: correct empty compression property behavior
Date: Thu, 16 Oct 2014 03:37:03 +0200 [thread overview]
Message-ID: <543F213F.5090308@jp.fujitsu.com> (raw)
In-Reply-To: <20140929163646.GF11436@twin.jikos.cz>
Hi David and Chris,
(2014/09/29 18:36), David Sterba wrote:
> On Fri, Sep 19, 2014 at 05:45:49PM +0900, Satoru Takeuchi wrote:
>> In the current implementation, compression property == "" has
>> the two different meanings: one is with BTRFS_INODE_NOCOMPRESS,
>> and the other is without this flag.
>>
>> So, even if the two files a and b have the same compression
>> property, "", and the same contents, one file seems to be
>> compressed and the other is not. It's difficult to understand
>> for users and also confuses them.
>
> Fixing this inconsistency is good, let me think more about the
> interface.
How about these patches? These patches seems not to be merged yet.
Especially patch 4/4 resolve the bug that atomic two operations
are separated to the different two transactions. I consider this
patch should be applied as soon as possible.
Thanks,
Satoru
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-10-16 1:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 8:45 [PATCH 1/4] btrfs: correct empty compression property behavior Satoru Takeuchi
2014-09-19 8:48 ` [PATCH 2/4] btrfs: introduce new compression property to disable compression at all Satoru Takeuchi
2014-09-19 8:52 ` [PATCH 3/4] btrfs: export __btrfs_set_prop Satoru Takeuchi
2014-09-19 9:05 ` [PATCH 4/4] btrfs: Fix compression related ioctl to run atomic operations in one transaction Satoru Takeuchi
2014-09-25 5:57 ` [PATCH v2 " Satoru Takeuchi
2014-09-22 12:01 ` [PATCH 3/4] btrfs: export __btrfs_set_prop David Sterba
2014-09-25 5:55 ` [PATCH v2 3/4] btrfs: Rename and export __btrfs_set_prop to be called from running transaction Satoru Takeuchi
2014-09-29 16:23 ` David Sterba
2014-09-29 16:36 ` [PATCH 1/4] btrfs: correct empty compression property behavior David Sterba
2014-10-16 1:37 ` Satoru Takeuchi [this message]
2014-10-16 7:01 ` Filipe David Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543F213F.5090308@jp.fujitsu.com \
--to=takeuchi_satoru@jp.fujitsu.com \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=fdmanana@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=naota@elisp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.