From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: <hliang1025@gmail.com>
Cc: David Miller <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<adi-linux-docs@lists.sourceforge.net>
Subject: Re: [PATCH] net: ethernet : stmicro: fixed power suspend and resume failure in stmmac driver
Date: Thu, 16 Oct 2014 10:58:22 +0200 [thread overview]
Message-ID: <543F88AE.2020702@st.com> (raw)
In-Reply-To: <20141001.134508.1301867654128829684.davem@davemloft.net>
Hello Hao Liang
On 10/1/2014 7:45 PM, David Miller wrote:
> From: Hao Liang <hliang1025@gmail.com>
> Date: Wed, 1 Oct 2014 14:08:28 +0800
>
>> I double-check my patch and the ->mac->xxx calls are still under the lock.
>> I think that lock is trying to protect priv struct and related data, so i
>> just remove some functions have no bearing on priv struct.
>
> It's preventing parallel invocations of the ->mac->xxx calls.
>
> The other instances are in device open/close, where RTNL semaphore is
> held, and no other code paths in the driver can be active.
>
> You need the lock.
Do you have a new patch for this problem after David's advice?
I am reviewing the patches sent some weeks ago for driver looking
and I can also try to fix this in case of you have no news.
Let me know,
Regards,
peppe
next prev parent reply other threads:[~2014-10-16 8:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 5:55 [PATCH] net: ethernet : stmicro: fixed power suspend and resume failure in stmmac driver hliang1025
2014-09-30 13:00 ` Giuseppe CAVALLARO
2014-09-30 19:10 ` David Miller
[not found] ` <CAPig_t=oA6BuAt77DDsLqrtRBDbV_vsoAxM31XxLjkAFpYG1-Q@mail.gmail.com>
2014-10-01 17:45 ` David Miller
2014-10-16 8:58 ` Giuseppe CAVALLARO [this message]
[not found] ` <CAPig_t=Dguhw8jmAX_KvMrB9ZjL1POB+7jrdBmwpvTzjasKD1w@mail.gmail.com>
2014-10-20 15:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543F88AE.2020702@st.com \
--to=peppe.cavallaro@st.com \
--cc=adi-linux-docs@lists.sourceforge.net \
--cc=davem@davemloft.net \
--cc=hliang1025@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.