From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42839)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1Xeh4P-0001Yr-Hj
	for qemu-devel@nongnu.org; Thu, 16 Oct 2014 05:10:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1Xeh4K-0000i5-If
	for qemu-devel@nongnu.org; Thu, 16 Oct 2014 05:10:05 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:9774)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1Xeh4J-0000d4-Rc
	for qemu-devel@nongnu.org; Thu, 16 Oct 2014 05:10:00 -0400
Message-ID: <543F8B4A.4020104@huawei.com>
Date: Thu, 16 Oct 2014 17:09:30 +0800
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
MIME-Version: 1.0
References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com>
	<1412358473-31398-17-git-send-email-dgilbert@redhat.com>
	<543F814F.6030105@huawei.com> <20141016083501.GG2590@work-vm>
In-Reply-To: <20141016083501.GG2590@work-vm>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of
 return path
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com

On 2014/10/16 16:35, Dr. David Alan Gilbert wrote:
> * zhanghailiang (zhang.zhanghailiang@huawei.com) wrote:
>
>>> +        case MIG_RPCOMM_ACK:
>>> +            tmp32 = be32_to_cpup((uint32_t *)buf);
>>> +            DPRINTF("RP: Received ACK 0x%x", tmp32);
>>> +            atomic_xchg(&ms->rp_state.latest_ack, tmp32);
>>
>> I didn't see *ms->rp_state.latest_ack* been used elsewhere, what's it used for?;)
>
> Nothing currently; I've used the REQ/ACK as debug at the moment;   I was thinking
> that someone might want to wait on an ack being received before carrying on; but hadn't
> actually needed it in postcopy.
>

OK, i see, Thanks.

> Dave
>
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
>
> .
>