All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Matt Wilson <msw@linux.com>, "Zhang, Yang Z" <yang.z.zhang@intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
	"Wu, Feng" <feng.wu@intel.com>, Jan Beulich <JBeulich@suse.com>,
	"Dong, Eddie" <eddie.dong@intel.com>,
	"Dugger, Donald D" <donald.d.dugger@intel.com>,
	"Nakajima, Jun" <jun.nakajima@intel.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: x2APIC MSR range (XSA-108 follow-up)
Date: Thu, 16 Oct 2014 10:56:01 +0100	[thread overview]
Message-ID: <543F9631.7020700@citrix.com> (raw)
In-Reply-To: <20141016075706.GA20604@u109add4315675089e695.ant.amazon.com>

On 16/10/14 08:57, Matt Wilson wrote:
> On Tue, Oct 14, 2014 at 06:23:52AM +0000, Zhang, Yang Z wrote:
>> Wu, Feng wrote on 2014-10-14:
>>> The SDM 10.12.1.2 says:
>>>
>>> " Addresses in the range 800H¨CBFFH that are not listed in Table 10-6
>>> (including 80EH and 831H) are reserved.
>>> Executions of RDMSR and WRMSR that attempt to access such addresses
>>> cause general-protection exceptions. "
>>>
>>> Table 10-6. Local APIC Register Address Map Supported by x2APIC
>>>
>>> Why should we virtualize those reserved MSRs for guests?
>> IIUC the question should be why those undocumented MSRs exist on
>> real hardware and what do they do? Will guest access to them via
>> check CPU model? If yes, how can we virtualize them correctly?
> I suspect that Intel knows what they are and what they do. I imagine
> that both are CPU model specific.
>
>> I don't have the answer right now but I will forward the question to
>> hardware guy for more help.
> Since these MSRs are not part of the SDM or any public platform
> documentation as far as I can tell, I imagine that they are for
> BIOS-level functionality that does not have meaning in a virtual
> environment today and presents no OS compatibility problem if we
> choose to #GP all access to them.
>
> Short of some reply from Intel saying "No! That will break some OS" I
> think that we should make the x2APIC MSR code handle 0x800...0xbff and
> #GP any access that is above the emulated area.

I have a patch like this currently getting a kicking in our dedicated
XSA-108 test set.  I will report back with how it does.

~Andrew

  reply	other threads:[~2014-10-16  9:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-13  6:45 x2APIC MSR range (XSA-108 follow-up) Jan Beulich
2014-10-13  9:26 ` Anthony Liguori
2014-10-13  9:45   ` Jan Beulich
2014-10-13  9:52 ` Supporting default reads of host MSRs [WAS: x2APIC MSR range (XSA-108 follow-up)] Andrew Cooper
2014-10-13 11:00   ` Supporting default reads of host MSRs Matt Wilson
2014-10-13 11:40   ` Supporting default reads of host MSRs [WAS: x2APIC MSR range (XSA-108 follow-up)] Anthony Liguori
2014-10-13 13:35     ` Andrew Cooper
2014-10-13 14:11       ` Anthony Liguori
2014-10-13 10:57 ` x2APIC MSR range (XSA-108 follow-up) Matt Wilson
2014-10-14  3:00   ` Wu, Feng
2014-10-14  6:23     ` Zhang, Yang Z
2014-10-14  9:59       ` Jan Beulich
2014-10-16  7:57       ` Matt Wilson
2014-10-16  9:56         ` Andrew Cooper [this message]
2014-10-14  7:07   ` Zhang, Yang Z
2014-10-14  7:55     ` Matt Wilson
2014-10-14  9:59     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=543F9631.7020700@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=donald.d.dugger@intel.com \
    --cc=eddie.dong@intel.com \
    --cc=feng.wu@intel.com \
    --cc=jun.nakajima@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=msw@linux.com \
    --cc=xen-devel@lists.xenproject.org \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.