From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api Date: Thu, 16 Oct 2014 07:10:37 -0600 Message-ID: <543FC3CD.8050805@osg.samsung.com> References: <543FB374.8020604@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <543FB374.8020604@metafoo.de> Sender: linux-kernel-owner@vger.kernel.org To: Lars-Peter Clausen , m.chehab@samsung.com, akpm@linux-foundation.org, gregkh@linuxfoundation.org, crope@iki.fi, olebowle@gmx.com, dheitmueller@kernellabs.com, hverkuil@xs4all.nl, ramakrmu@cisco.com, sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com, perex@perex.cz, tiwai@suse.de, prabhakar.csengg@gmail.com, tim.gardner@canonical.com, linux@eikelenboom.it Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-media@vger.kernel.org List-Id: alsa-devel@alsa-project.org On 10/16/2014 06:00 AM, Lars-Peter Clausen wrote: > On 10/14/2014 04:58 PM, Shuah Khan wrote: > [...] >> switch (cmd) { >> case SNDRV_PCM_TRIGGER_START: >> + err = media_get_audio_tkn(&subs->dev->dev); >> + if (err == -EBUSY) { >> + dev_info(&subs->dev->dev, "%s device is busy\n", >> + __func__); > > In my opinion this should not dev_info() as this is out of band error > signaling and also as the potential to spam the log. The userspace > application is already properly notified by the return code. > Yes it has the potential to flood the dmesg especially with alsa, I will remove the dev_info(). thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978