From: Max Reitz <mreitz@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: fix implicit convertion to invalid type
Date: Thu, 16 Oct 2014 15:39:13 +0200 [thread overview]
Message-ID: <543FCA81.7060703@redhat.com> (raw)
In-Reply-To: <543FC94A.4040409@redhat.com>
Am 16.10.2014 um 15:34 schrieb Max Reitz:
> Am 16.10.2014 um 14:10 schrieb Igor Mammedov:
>> change type of variable to expected IoOperationType which fixes compile
>> warning:
>>
>> block.c:3655:20: warning: implicit conversion from enumeration
>> type enum IoOperationType to different enumeration type
>> BlockErrorAction
>>
>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>> ---
>> block.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
Oh, I had the feeling I was forgetting something. The subject should
read "conversion", not "convertion". Feel free to keep my R-b if you
send a v2 to fix it.
Max
next prev parent reply other threads:[~2014-10-16 13:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 12:10 [Qemu-devel] [PATCH] block: fix implicit convertion to invalid type Igor Mammedov
2014-10-16 13:34 ` Max Reitz
2014-10-16 13:39 ` Max Reitz [this message]
2014-10-28 15:11 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543FCA81.7060703@redhat.com \
--to=mreitz@redhat.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.