All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	xen-devel@lists.xensource.com
Cc: julien.grall@citrix.com, Ian.Campbell@citrix.com
Subject: Re: [PATCH v6 3/8] xen/arm: return int *_dcache_va_range
Date: Thu, 16 Oct 2014 16:06:52 +0100	[thread overview]
Message-ID: <543FDF0C.1000108@linaro.org> (raw)
In-Reply-To: <1413470755-30991-3-git-send-email-stefano.stabellini@eu.citrix.com>

Hi Stefano,

On 10/16/2014 03:45 PM, Stefano Stabellini wrote:
> These functions cannot really fail on ARM, but their x86 equivalents can
> (-EOPNOTSUPP). Change the prototype to return int.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

I was wondering if we should add a comment in the helpers in case
someone decides to return a non-zero value. If so we will have to check
the return in the caller.

But I guess it will never happen. So either way:

Reviewed-by: Julien Grall <julien.grall@linaro.org>

Regards,

-- 
Julien Grall

  reply	other threads:[~2014-10-16 15:06 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-16 14:44 [PATCH v6 0/8] xen/arm: introduce GNTTABOP_cache_flush Stefano Stabellini
2014-10-16 14:45 ` [PATCH v6 1/8] xen: introduce gnttab_max_frames and gnttab_max_maptrack_frames command line options Stefano Stabellini
2014-10-16 16:15   ` Jan Beulich
2014-10-16 16:56     ` Stefano Stabellini
2014-10-16 16:57       ` Stefano Stabellini
2014-10-17  8:44       ` Jan Beulich
2014-10-16 14:45 ` [PATCH v6 2/8] xen/arm: rename *_xen_dcache_* operations to *_dcache_* Stefano Stabellini
2014-10-16 14:45 ` [PATCH v6 3/8] xen/arm: return int *_dcache_va_range Stefano Stabellini
2014-10-16 15:06   ` Julien Grall [this message]
2014-10-16 14:45 ` [PATCH v6 4/8] xen/arm: introduce invalidate_dcache_va_range Stefano Stabellini
2014-10-16 14:45 ` [PATCH v6 5/8] xen/x86: introduce more cache maintenance operations Stefano Stabellini
2014-10-16 16:18   ` Jan Beulich
2014-10-16 14:45 ` [PATCH v6 6/8] xen/arm: introduce GNTTABOP_cache_flush Stefano Stabellini
2014-10-16 16:25   ` Jan Beulich
2014-10-16 16:30     ` Stefano Stabellini
2014-10-17  8:46       ` Jan Beulich
2014-10-16 17:03   ` David Vrabel
2014-10-16 17:29     ` Stefano Stabellini
2014-10-16 17:47       ` David Vrabel
2014-10-17 10:01         ` Stefano Stabellini
2014-10-17 10:23           ` Jan Beulich
2014-10-17  9:44       ` Jan Beulich
2014-10-16 14:45 ` [PATCH v6 7/8] Revert "xen/arm: introduce XENFEAT_grant_map_identity" Stefano Stabellini
2014-10-16 14:45 ` [PATCH v6 8/8] Revert "xen: introduce arch_grant_(un)map_page_identity" Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=543FDF0C.1000108@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=Ian.Campbell@citrix.com \
    --cc=julien.grall@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.