From: Emil Velikov <emil.l.velikov@gmail.com>
To: "Cheng, Yao" <yao.cheng@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "Vetter, Daniel" <daniel.vetter@intel.com>,
emil.l.velikov@gmail.com, "Jiang, Fei" <fei.jiang@intel.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [RFC PATCH 3/3] libdrm: user mode helper for ipvr drm driver
Date: Thu, 16 Oct 2014 16:20:22 +0100 [thread overview]
Message-ID: <543FE236.3000406@gmail.com> (raw)
In-Reply-To: <8FF7D634BEE4C2428EFFAB6B7E919E4B017BCEB8@shsmsx102.ccr.corp.intel.com>
On 16/10/14 15:33, Cheng, Yao wrote:
> Hi Emil,
> Sorry, what do you mean by "correctly aligned"? does it mean the paddings in this data structure?
>
Afaict for compatibility reasons the struct size have to be "aligned"
(multiple of 8 bytes), or if you prefer - the struct is missing the
required padding :) I've only skimmed through the patch so it may be
that other structs are having this issue.
Cheers,
Emil
>> -----Original Message-----
>> From: Emil Velikov [mailto:emil.l.velikov@gmail.com]
>> Sent: Wednesday, October 15, 2014 5:24 PM
>> To: Cheng, Yao; intel-gfx@lists.freedesktop.org
>> Cc: emil.l.velikov@gmail.com; Jiang, Fei; dri-devel@lists.freedesktop.org;
>> Vetter, Daniel
>> Subject: Re: [RFC PATCH 3/3] libdrm: user mode helper for ipvr drm driver
>>
>> Hi Yao,
>>
>> struct drm_ipvr_gem_userptr does not seem to be correctly aligned - is
>> that intentional ? Might be worth checking if anything else in
>> ipvr_drm.h and ipvr_bufmgr.h is in the same boat.
>>
>> Cheers,
>> Emil
>>
next prev parent reply other threads:[~2014-10-16 15:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 12:15 [RFC PATCH 3/3] libdrm: user mode helper for ipvr drm driver Yao Cheng
2014-10-15 9:23 ` Emil Velikov
2014-10-16 14:33 ` Cheng, Yao
2014-10-16 15:20 ` Emil Velikov [this message]
2014-10-17 0:36 ` Cheng, Yao
2014-10-17 0:36 ` Jiang, Fei
2014-10-28 16:56 ` Daniel Stone
2014-10-29 7:09 ` Cheng, Yao
2014-10-29 8:14 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543FE236.3000406@gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fei.jiang@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=yao.cheng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.