All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bod@kernel.org>
To: Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
	Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>,
	Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
Subject: Re: [PATCH v4 1/3] dt-bindings: media: qcom,qcm2290-venus: document shikra Iris compatible
Date: Fri, 31 Jul 2026 14:39:54 +0100	[thread overview]
Message-ID: <543f447c-bd6a-41ae-a413-fa2eb74be9a0@kernel.org> (raw)
In-Reply-To: <20260721-shikra_vpu-v4-1-6dc5a8999b73@oss.qualcomm.com>

On 21/07/2026 18:32, Vikash Garodia wrote:
> diff --git a/Documentation/devicetree/bindings/media/qcom,venus-common.yaml b/Documentation/devicetree/bindings/media/qcom,venus-common.yaml
> index 59a3fde846d2196ab1e4588eb396012ba6860712..0be2f9119e78233928d23af86836ac294aa769ee 100644
> --- a/Documentation/devicetree/bindings/media/qcom,venus-common.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,venus-common.yaml
> @@ -37,7 +37,10 @@ properties:
>       maxItems: 20
> 
>     memory-region:
> -    maxItems: 1
> +    minItems: 1
> +    items:
> +      - description: Firmware-loaded codec carveout
> +      - description: IOMMU IOVA reservation region

So we discussed separately the pixel and non-pixel sub-nodes as well as 
this basically alternate means of memory delination.

What I'd like is a clear statement

- Committing to this scheme for existing platforms
- Adding the pixel and sub-pixel to the shared
- Backporting at least one method to -stable

For that reason this extension should at a minimum be its own commit 
with a well articulated commit log.

Since this is minItems: 1 it is conceviable to land both this and the 
sub-node into the same file.

But my continued feedback and objection is not being clear about what's 
being done and having two separate methods without a clear roadmap.

You have your sub-node RFC and this change - I won't say sneaking in 
here but, its a surreptitious change as given as-is.

- Which method
- Both ? Then what goes to -stable

We also discussed offline the fact that right-now the lack of a means of 
addressing this in upstream means we are in effect leaving a known 
critical bug open to the vagaries of IOVA allocation @ runtime across 
every single venus and iris there is.

So to me minItems: 1 for -stable _in_this_kernel_cycle_ is warranted.

---
bod

  parent reply	other threads:[~2026-07-31 13:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21 17:32 [PATCH v4 0/3] media: qcom: Add support for the iris codec on shikra Vikash Garodia
2026-07-21 17:32 ` [PATCH v4 1/3] dt-bindings: media: qcom,qcm2290-venus: document shikra Iris compatible Vikash Garodia
2026-07-22  7:15   ` Krzysztof Kozlowski
2026-07-22 10:57     ` Vikash Garodia
2026-07-31 11:57   ` Dmitry Baryshkov
2026-07-31 12:44     ` Vikash Garodia
2026-07-31 14:10       ` Dmitry Baryshkov
2026-07-31 13:39   ` Bryan O'Donoghue [this message]
2026-07-31 14:01     ` Bryan O'Donoghue
2026-07-21 17:32 ` [PATCH v4 2/3] arm64: dts: qcom: shikra: Add Iris video codec node Vikash Garodia
2026-07-21 17:32 ` [PATCH v4 3/3] arm64: dts: qcom: shikra-evk: Enable Iris core Vikash Garodia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=543f447c-bd6a-41ae-a413-fa2eb74be9a0@kernel.org \
    --to=bod@kernel.org \
    --cc=andersson@kernel.org \
    --cc=busanna.reddy@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dikshita.agarwal@oss.qualcomm.com \
    --cc=jorge.ramirez@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=stanimir.k.varbanov@gmail.com \
    --cc=vikash.garodia@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.