From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH for-4.5] tools/libxl: Fix building against
 libxl for LIBXL_API_VERSION < 0x040500
Date: Fri, 17 Oct 2014 12:01:54 +0100
Message-ID: <5440F722.4090209@citrix.com>
References: <1413536179-21129-1-git-send-email-andrew.cooper3@citrix.com>
	<21568.63163.931343.323308@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21568.63163.931343.323308@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 17/10/14 12:00, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH for-4.5] tools/libxl: Fix building against libxl for LIBXL_API_VERSION < 0x040500"):
>> c/s 6276f66ebe "libxl: libxl_uuid_copy now takes a ctx argument" introduces
>> API compatibiltiy for libxl_uuid_copy() which sadly is not valid C.  Fix it.
> ...
>>  #if defined(LIBXL_API_VERSION) && LIBXL_API_VERSION < 0x040500
>> -void libxl_uuid_copy(dst, src) libxl_uuid_copy(NULL, dst, src)
> I think this was intended to read
>   #define libxl_uuid_copy(dst, src) libxl_uuid_copy(NULL, dst, src)
> but should in fact read
>   #define libxl_uuid_copy(dst, src) libxl_uuid_copy(NULL, (dst), (src))

Does this even work?

Won't the parser complain about passing 3 parameters to a two-parameter
macro?

~Andrew