From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH 1/2] libxl: Fix a couple of log messages to print correct errnos Date: Fri, 17 Oct 2014 08:24:57 -0400 Message-ID: <54410A99.2000404@terremark.com> References: <21566.40395.18224.864777@mariner.uk.xensource.com> <1413481453-25801-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1413481453-25801-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , xen-devel@lists.xensource.com Cc: ian.campbell@eu.citrix.com, Wei Liu List-Id: xen-devel@lists.xenproject.org On 10/16/14 13:44, Ian Jackson wrote: > xc_domain_create and xc_cpupool_movedomain do not return errno values; > they return -1 and set errno. Fix the logging accordingly. > > Signed-off-by: Ian Jackson > --- > tools/libxl/libxl_create.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c > index 8b82584..8ae9701 100644 > --- a/tools/libxl/libxl_create.c > +++ b/tools/libxl/libxl_create.c > @@ -515,14 +515,14 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_create_info *info, > > ret = xc_domain_create(ctx->xch, info->ssidref, handle, flags, domid); > if (ret < 0) { > - LIBXL__LOG_ERRNOVAL(ctx, LIBXL__LOG_ERROR, ret, "domain creation fail"); > + LIBXL__LOG_ERRNO(ctx, LIBXL__LOG_ERROR, "domain creation fail"); > rc = ERROR_FAIL; > goto out; > } > > ret = xc_cpupool_movedomain(ctx->xch, info->poolid, *domid); > if (ret < 0) { > - LIBXL__LOG_ERRNOVAL(ctx, LIBXL__LOG_ERROR, ret, "domain move fail"); > + LIBXL__LOG_ERRNO(ctx, LIBXL__LOG_ERROR, "domain move fail"); > rc = ERROR_FAIL; > goto out; > } Looks good. Reviewed-by: Don Slutz