From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH v1] tty: serial: 8250_core: restore the LCR register in set_sleep Date: Fri, 17 Oct 2014 08:46:24 -0400 Message-ID: <54410FA0.6000903@hurleysoftware.com> References: <1413549558-24227-1-git-send-email-ssreedharan@mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1413549558-24227-1-git-send-email-ssreedharan@mvista.com> Sender: linux-kernel-owner@vger.kernel.org To: Sudhir Sreedharan , gregkh@linuxfoundation.org Cc: khilman@kernel.org, linux-serial@vger.kernel.org, jslaby@suse.cz, linux-kernel@vger.kernel.org, olof@lixom.net, linux-arm-kernel@lists.infradead.org, geert@linux-m68k.org List-Id: linux-serial@vger.kernel.org On 10/17/2014 08:39 AM, Sudhir Sreedharan wrote: > In ST16650V2 based serial uarts, while initalizing the PM state, > LCR registers are being initialized to 0 in serial8250_set_sleep(). > If console port is already initialized and being used, this will > throws garbage in the console. Thanks. Reviewed-by: Peter Hurley From mboxrd@z Thu Jan 1 00:00:00 1970 From: peter@hurleysoftware.com (Peter Hurley) Date: Fri, 17 Oct 2014 08:46:24 -0400 Subject: [PATCH v1] tty: serial: 8250_core: restore the LCR register in set_sleep In-Reply-To: <1413549558-24227-1-git-send-email-ssreedharan@mvista.com> References: <1413549558-24227-1-git-send-email-ssreedharan@mvista.com> Message-ID: <54410FA0.6000903@hurleysoftware.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/17/2014 08:39 AM, Sudhir Sreedharan wrote: > In ST16650V2 based serial uarts, while initalizing the PM state, > LCR registers are being initialized to 0 in serial8250_set_sleep(). > If console port is already initialized and being used, this will > throws garbage in the console. Thanks. Reviewed-by: Peter Hurley