From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH for-4.5] tools/libxl: Fix building against libxl for LIBXL_API_VERSION < 0x040500 Date: Fri, 17 Oct 2014 15:19:46 +0100 Message-ID: <54412582.8050203@citrix.com> References: <1413536179-21129-1-git-send-email-andrew.cooper3@citrix.com> <21568.63163.931343.323308@mariner.uk.xensource.com> <5440F722.4090209@citrix.com> <21568.63504.42838.728406@mariner.uk.xensource.com> <21568.63641.51091.765530@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21568.63641.51091.765530@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , Xen-devel , Ian Campbell , Wei Liu List-Id: xen-devel@lists.xenproject.org On 17/10/14 12:08, Ian Jackson wrote: > Ian Jackson writes ("Re: [PATCH for-4.5] tools/libxl: Fix building against libxl for LIBXL_API_VERSION < 0x040500"): >> Andrew Cooper writes ("Re: [PATCH for-4.5] tools/libxl: Fix building against libxl for LIBXL_API_VERSION < 0x040500"): >>> On 17/10/14 12:00, Ian Jackson wrote: >>>> I think this was intended to read >>>> #define libxl_uuid_copy(dst, src) libxl_uuid_copy(NULL, dst, src) >>>> but should in fact read >>>> #define libxl_uuid_copy(dst, src) libxl_uuid_copy(NULL, (dst), (src)) > Having checked the rules, for C++ this might conceivably have to be > #define libxl_uuid_copy(dst, src) (libxl_uuid_copy(NULL, (dst), (src))) > > Ian. Fundamentally, I am not really fussed how this is fixed, although I have confirmed my patch fixes the libvirt build in the XenServer branch I am attempting to test Xen-4.5 under. ~Andrew