From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35140)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mikhail.sennikovskii@profitbricks.com>)
	id 1Xf9bg-0006qD-Vz
	for qemu-devel@nongnu.org; Fri, 17 Oct 2014 11:38:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mikhail.sennikovskii@profitbricks.com>)
	id 1Xf9bZ-0005Dj-HH
	for qemu-devel@nongnu.org; Fri, 17 Oct 2014 11:38:20 -0400
Received: from mail-lb0-f173.google.com ([209.85.217.173]:48774)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mikhail.sennikovskii@profitbricks.com>)
	id 1Xf9bZ-0005DP-BH
	for qemu-devel@nongnu.org; Fri, 17 Oct 2014 11:38:13 -0400
Received: by mail-lb0-f173.google.com with SMTP id 10so904170lbg.18
	for <qemu-devel@nongnu.org>; Fri, 17 Oct 2014 08:38:12 -0700 (PDT)
Received: from [192.168.71.100] ([62.217.45.26])
	by mx.google.com with ESMTPSA id m5sm549405laj.8.2014.10.17.08.38.10
	for <qemu-devel@nongnu.org>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Fri, 17 Oct 2014 08:38:10 -0700 (PDT)
Message-ID: <544137E1.7050908@profitbricks.com>
Date: Fri, 17 Oct 2014 17:38:09 +0200
From: Mikhail Sennikovskii <mikhail.sennikovskii@profitbricks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] memory hotplug with 2.1.2
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hi all,

Trying to hotplug RAM with qemu 2.1.2 using

object_add memory-backend-ram,id=ram1,size=128M
device_add pc-dimm,id=dimm1,memdev=ram1

gives the following error:
{{{
'DIMM property node has value 0' which exceeds the number of numa nodes: 0
Device 'pc-dimm' could not be initialized
}}}

which goes away if I add a "dummy" numa node via command line at VM 
creation  -numa node,nodeid=0

This behavior was introduced by the commit 
9a72433843d912a45046959b1953861211d1838d, and disabling the check makes 
the hotplug work again for me.

Is this a regression, or just some memory hotplug semantic change? And 
in the latter case, could you specify the proper semantic I should use?

Thanks,
Mikhail