All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Rae <srae@broadcom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] aboot: fix block addressing for don't care chunk type
Date: Fri, 17 Oct 2014 10:17:41 -0700	[thread overview]
Message-ID: <54414F35.3000005@broadcom.com> (raw)
In-Reply-To: <1413429576-15336-1-git-send-email-robherring2@gmail.com>

Hi Rob:

THANKS!

On 14-10-15 08:19 PM, Rob Herring wrote:
> From: Rob Herring <robh@kernel.org>
>
> CHUNK_TYPE_DONT_CARE should skip over the specified number of blocks, but
> currently fails to increment the device block address. This results in
> filesystem images getting written incorrectly. Add the missing block
> address incrementing.
>
> Cc: Steve Rae <srae@broadcom.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>   common/aboot.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/common/aboot.c b/common/aboot.c
> index d5c464b..fba8e3e 100644
> --- a/common/aboot.c
> +++ b/common/aboot.c
> @@ -208,6 +208,7 @@ void write_sparse_image(block_dev_desc_t *dev_desc,
>   			break;
>
>   			case CHUNK_TYPE_DONT_CARE:
> +			blk += blkcnt;
>   			total_blocks += chunk_header->chunk_sz;
>   			break;
>
>

Reviewed-by: Steve Rae <srae@broadcom.com>

  reply	other threads:[~2014-10-17 17:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-16  3:19 [U-Boot] [PATCH] aboot: fix block addressing for don't care chunk type Rob Herring
2014-10-17 17:17 ` Steve Rae [this message]
2014-10-27 22:21 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54414F35.3000005@broadcom.com \
    --to=srae@broadcom.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.