From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?windows-1252?Q?Christian_K=F6nig?= Subject: Re: order 5 memory allocation failures in radeon_vm_get_bos Date: Fri, 17 Oct 2014 19:30:26 +0200 Message-ID: <54415232.5040606@vodafone.de> References: <544088DE.6020904@daenzer.net> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from pegasos-out.vodafone.de (pegasos-out.vodafone.de [80.84.1.38]) by gabe.freedesktop.org (Postfix) with ESMTP id DFE7D6E35A for ; Fri, 17 Oct 2014 10:30:35 -0700 (PDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by pegasos-out.vodafone.de (Rohrpostix2 Daemon) with ESMTP id 090F65F8B74 for ; Fri, 17 Oct 2014 19:30:34 +0200 (CEST) Received: from pegasos-out.vodafone.de ([127.0.0.1]) by localhost (rohrpostix2.prod.vfnet.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NCrGnVig5Oo2 for ; Fri, 17 Oct 2014 19:30:32 +0200 (CEST) In-Reply-To: <544088DE.6020904@daenzer.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?windows-1252?Q?Michel_D=E4nzer?= , Dave Airlie Cc: dri-devel List-Id: dri-devel@lists.freedesktop.org Am 17.10.2014 um 05:11 schrieb Michel D=E4nzer: > On 17.10.2014 09:23, Dave Airlie wrote: >> I have someone running F20 + a hacked up glamor to fix some leaks, >> however he is getting >> order 4/5 memory allocation failures in the kmalloc_array in = >> radeon_vm_get_bos >> >> radeon_vm_get_bos+0x30/0x120 >> >> I think we should fallback to vmalloc or just use drm_malloc_ab in = >> here instead, >> >> any reason we haven't? > > I don't think so, see = > https://bugs.freedesktop.org/show_bug.cgi?id=3D81991 . I didn't know = > about drm_malloc_ab, that looks like the easiest fix indeed. Mhm fixing this using another allocator function is probably a good = idea, but on the other hand why does X want to allocate an order 4/5 in = vm_get_bos in the first place? Assuming 64 bytes per array element that would mean that we have over 1K = BOs for the address space handling. Even with the lowest settings on BO = size that covers something like 4GB of GPU address space and with normal = settings it is more something like 256GB... So question here is why does X need so much GPU address space? The box = doesn't even have so much memory, doesn't it? Cheers, Christian.