All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: Mikhail Sennikovskii <mikhail.sennikovskii@profitbricks.com>,
	Andrey Korolyov <andrey@xdel.ru>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] memory hotplug with 2.1.2
Date: Sat, 18 Oct 2014 10:39:14 +0800	[thread overview]
Message-ID: <5441D2D2.4040908@huawei.com> (raw)
In-Reply-To: <CALHVEJZLxJnSTb7mA9C7ucmphc70uJ-W4Kvdu-5cMbbE_t5paQ@mail.gmail.com>

Hi,

Have you tried the latest qemu (you can git clone from http://git.qemu.org/qemu.git).

Actually, i have posted a patch fc50ff0666315be5120c70ad00cd0b0097484b84
     pc-dimm: Don't check dimm->node when there is non-NUMA config

     It should not break memory hotplug feature if there is non-NUMA option.

     This patch would also allow to use pc-dimm as replacement for initial memory
     for non-NUMA configs.

     Note: After this patch, the memory hotplug can work normally for Linux guest OS
     when there is non-NUMA option and NUMA option. But not support Windows guest OS
     to hotplug memory with no-NUMA config, actully, it's Windows limitation.

     Reviewed-By: Igor Mammedov <imammedo@redhat.com>
     Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
     Acked-by: Michael S. Tsirkin <mst@redhat.com>
     Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

I think this will fix your problem, it will support hotplug a pc-dimm without configure numa node.

Hope this can help you, Thanks

Best Regards,
zhanghailiang

On 2014/10/18 1:11, Mikhail Sennikovskii wrote:
> Hi Andrey, thank you for your answer.
>
> I know I can work around this by specifying a numa node.
> My question is though is the current behaviour considered to be a bug, or
> not. And if yes, when it is expected to get fixed.
>
> Thanks,
> Mikhail
>
> On Fri, Oct 17, 2014 at 5:54 PM, Andrey Korolyov <andrey@xdel.ru> wrote:
>
>> Please try to populate basic (single-node) NUMA topology to workaround
>> this (or specify numa node for dimm).
>>
>

      reply	other threads:[~2014-10-18  2:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-17 15:38 [Qemu-devel] memory hotplug with 2.1.2 Mikhail Sennikovskii
2014-10-17 15:46 ` Mikhail Sennikovskii
     [not found]   ` <CABYiri9+8D=rTVfoJXipy3q8J_bRjnk58D7csPT6jHok4FxnHg@mail.gmail.com>
2014-10-17 17:11     ` Mikhail Sennikovskii
2014-10-18  2:39       ` zhanghailiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5441D2D2.4040908@huawei.com \
    --to=zhang.zhanghailiang@huawei.com \
    --cc=andrey@xdel.ru \
    --cc=mikhail.sennikovskii@profitbricks.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.