diff for duplicates of <54427D5D.70603@cogentembedded.com> diff --git a/a/1.txt b/N1/1.txt index 0006213..b7b57ad 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -41,7 +41,7 @@ On 10/16/2014 10:12 AM, Yoshihiro Kaneko wrote: > } > > - iowrite32(ALIGN(cam->out_width, 0x10), priv->base + VNIS_REG); -> + if (icd->current_fmt->host_fmt->fourcc = V4L2_PIX_FMT_NV16) +> + if (icd->current_fmt->host_fmt->fourcc == V4L2_PIX_FMT_NV16) > + imgstr = ALIGN(cam->out_width, 0x20); > + else > + imgstr = ALIGN(cam->out_width, 0x10); @@ -66,14 +66,14 @@ On 10/16/2014 10:12 AM, Yoshihiro Kaneko wrote: * bla */ -> + if (priv->error_flag = false) +> + if (priv->error_flag == false) > + priv->error_flag = true; I don't see where else you check this flag, it seems rather useless. I also don't see where you clear it, other than the "add/remove device" paths. > + else { -> + if ((pixfmt = V4L2_PIX_FMT_NV16) && (pix->width & 0x1F)) { +> + if ((pixfmt == V4L2_PIX_FMT_NV16) && (pix->width & 0x1F)) { > + dev_err(icd->parent, "Specified width error in NV16 format.\n"); > + return -EINVAL; > + } diff --git a/a/content_digest b/N1/content_digest index fcd6457..2ad6211 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01413439968-6349-3-git-send-email-ykaneko0929@gmail.com\0" "From\0Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>\0" "Subject\0Re: [PATCH v2 2/3] media: soc_camera: rcar_vin: Add capture width check for NV16 format\0" - "Date\0Sat, 18 Oct 2014 14:46:53 +0000\0" + "Date\0Sat, 18 Oct 2014 18:46:53 +0400\0" "To\0Yoshihiro Kaneko <ykaneko0929@gmail.com>" " linux-media@vger.kernel.org\0" "Cc\0Guennadi Liakhovetski <g.liakhovetski@gmx.de>" @@ -54,7 +54,7 @@ "> \t}\n" ">\n" "> -\tiowrite32(ALIGN(cam->out_width, 0x10), priv->base + VNIS_REG);\n" - "> +\tif (icd->current_fmt->host_fmt->fourcc = V4L2_PIX_FMT_NV16)\n" + "> +\tif (icd->current_fmt->host_fmt->fourcc == V4L2_PIX_FMT_NV16)\n" "> +\t\timgstr = ALIGN(cam->out_width, 0x20);\n" "> +\telse\n" "> +\t\timgstr = ALIGN(cam->out_width, 0x10);\n" @@ -79,14 +79,14 @@ " * bla\n" " */\n" "\n" - "> +\tif (priv->error_flag = false)\n" + "> +\tif (priv->error_flag == false)\n" "> +\t\tpriv->error_flag = true;\n" "\n" " I don't see where else you check this flag, it seems rather useless. I \n" "also don't see where you clear it, other than the \"add/remove device\" paths.\n" "\n" "> +\telse {\n" - "> +\t\tif ((pixfmt = V4L2_PIX_FMT_NV16) && (pix->width & 0x1F)) {\n" + "> +\t\tif ((pixfmt == V4L2_PIX_FMT_NV16) && (pix->width & 0x1F)) {\n" "> +\t\t\tdev_err(icd->parent, \"Specified width error in NV16 format.\\n\");\n" "> +\t\t\treturn -EINVAL;\n" "> +\t\t}\n" @@ -95,4 +95,4 @@ "\n" WBR, Sergei -823c7eaf9dd66410e34d2d4d8e3528c062ec54d28348da7d87455575f3ddb562 +edd884c26240bd5bf27c2258150715b5ac7f07139fd8d4c5cf0f3ddb75728f32
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.