From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <5442862A.4090408@gmx.at> Date: Sat, 18 Oct 2014 17:24:26 +0200 From: Manfred Schlaegl MIME-Version: 1.0 References: <544277C5.9030302@gmx.at> <54427C48.9050608@nod.at> <54428348.2050209@gmx.at> <54428500.6020304@nod.at> In-Reply-To: <54428500.6020304@nod.at> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Sender: linux-kernel-owner@vger.kernel.org Subject: Re: [PATCH] um: Remove unused bp stack-frame pointer To: Richard Weinberger , Jeff Dike Cc: Daniel Walter , Randy Dunlap , user-mode-linux-devel@lists.sourceforge.net, user-mode-linux-user@lists.sourceforge.net, linux-kernel@vger.kernel.org List-ID: On 2014-10-18 17:19, Richard Weinberger wrote: > Am 18.10.2014 um 17:12 schrieb Manfred Schlaegl: >> On 2014-10-18 16:42, Richard Weinberger wrote: >>> Am 18.10.2014 um 16:23 schrieb Manfred Schlaegl: >>>> The pointer to bp stack-frame is no longer used. Removed it. >>> >>> Good catch! >> Thank you. >> >>> >>>> This also removes a corresponding compiler-warning. >>> >>> Which warning exactly? >> >> On "normal" (defconfig) builds the warning does not show up because = CONFIG_FRAME_POINTER is set. >> I've found the unused bp because CONFIG_FRAME_POINTER was not set in= my configuration. >> >> CC arch/um/kernel/sysrq.o >> arch/um/kernel/sysrq.c: In function =91show_stack=92: >> arch/um/kernel/sysrq.c:32:29: warning: unused variable =91bp=92 [-Wu= nused-variable] >=20 > Looks like my gcc need's an upgrade. :D >=20 > Thanks, > //richard >=20 I'm using gcc version 4.7.2 (Debian 4.7.2-5). -> not THAT new ;-) best regards manfred -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751459AbaJRP2U (ORCPT ); Sat, 18 Oct 2014 11:28:20 -0400 Received: from mout.gmx.net ([212.227.15.18]:57520 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751095AbaJRP2R (ORCPT ); Sat, 18 Oct 2014 11:28:17 -0400 Message-ID: <5442862A.4090408@gmx.at> Date: Sat, 18 Oct 2014 17:24:26 +0200 From: Manfred Schlaegl User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Icedove/24.8.1 MIME-Version: 1.0 To: Richard Weinberger , Jeff Dike CC: Daniel Walter , Randy Dunlap , user-mode-linux-devel@lists.sourceforge.net, user-mode-linux-user@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] um: Remove unused bp stack-frame pointer References: <544277C5.9030302@gmx.at> <54427C48.9050608@nod.at> <54428348.2050209@gmx.at> <54428500.6020304@nod.at> In-Reply-To: <54428500.6020304@nod.at> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:/ENK74dS3P+q5rmvS+nGOWQSwzvkqlx0zKsS40jA2CMZrkDrMjb v0yg5+r1sDmx7bKXWanrwlfdqB369N2HxMfmzet+gV16z8gL4JFAaCXOsopnk0+Ih8gVmUq aGNlb7HlYapXQaEVUAJpRVGKu8NNtIWd3P4eYIuEjWbTFhU8EkHv/w7yFOJgosSVCRB2txD LRX1xSRGDgd+/eQ7QoYYw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014-10-18 17:19, Richard Weinberger wrote: > Am 18.10.2014 um 17:12 schrieb Manfred Schlaegl: >> On 2014-10-18 16:42, Richard Weinberger wrote: >>> Am 18.10.2014 um 16:23 schrieb Manfred Schlaegl: >>>> The pointer to bp stack-frame is no longer used. Removed it. >>> >>> Good catch! >> Thank you. >> >>> >>>> This also removes a corresponding compiler-warning. >>> >>> Which warning exactly? >> >> On "normal" (defconfig) builds the warning does not show up because CONFIG_FRAME_POINTER is set. >> I've found the unused bp because CONFIG_FRAME_POINTER was not set in my configuration. >> >> CC arch/um/kernel/sysrq.o >> arch/um/kernel/sysrq.c: In function ‘show_stack’: >> arch/um/kernel/sysrq.c:32:29: warning: unused variable ‘bp’ [-Wunused-variable] > > Looks like my gcc need's an upgrade. :D > > Thanks, > //richard > I'm using gcc version 4.7.2 (Debian 4.7.2-5). -> not THAT new ;-) best regards manfred