From: SF Markus Elfring <elfring at users.sourceforge.net>
To: powertop@lists.01.org
Subject: [Powertop] reserved identifier violation
Date: Sat, 18 Oct 2014 21:37:05 +0200 [thread overview]
Message-ID: <5442C161.4020107@users.sourceforge.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
Hello,
I would like to point out that identifiers like "__INCLUDE_GUARD_DISPLAY_H_" and
"_INCLUDE_GUARD_AHCI_H" do not fit to the expected naming convention of the C++
language standard.
Would you like to adjust your selection for unique names?
https://www.securecoding.cert.org/confluence/display/cplusplus/DCL32-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL32-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29
https://github.com/fenrus75/powertop/blob/54956f7407c0e369665cd9712a189f601c6ab545/src/display.h#L25
https://github.com/fenrus75/powertop/blob/d7455ba1d0125efed4780a2114ef66165d0cadc1/src/devices/ahci.h#L25
Regards,
Markus
next reply other threads:[~2014-10-18 19:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-18 19:37 SF Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-10-31 1:38 [Powertop] reserved identifier violation Alexandra Yates
2014-10-31 13:42 SF Markus Elfring
2014-10-31 23:22 Alexandra Yates
2014-11-01 8:58 SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5442C161.4020107@users.sourceforge.net \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.