From: SF Markus Elfring <elfring at users.sourceforge.net>
To: powertop@lists.01.org
Subject: [Powertop] Completion of error handling
Date: Sat, 18 Oct 2014 22:10:30 +0200 [thread overview]
Message-ID: <5442C936.3000303@users.sourceforge.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 738 bytes --]
Hello,
I have looked at a few source files for your current software. I have noticed
that some checks for return codes are missing.
Would you like to add more error handling for return values from functions like
the following?
- fputs ⇒ finish_report_output
https://github.com/fenrus75/powertop/blob/79123b34cf2cac2edeb918087dfc73f7b219cf54/src/report/report.cpp#L200
- pthread_create ⇒ cpu_calibration
https://github.com/fenrus75/powertop/blob/cdff23d6e40e31a68286a51e3c94c8a901a74091/src/calibrate/calibrate.cpp#L252
- pthread_join ⇒ extech_power_meter::end_measurement
https://github.com/fenrus75/powertop/blob/a5465a282107da5205b7928fe4ce4f642d1fd770/src/measurement/extech.cpp#L328
Regards,
Markus
next reply other threads:[~2014-10-18 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-18 20:10 SF Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-10-31 7:08 [Powertop] Completion of error handling SF Markus Elfring
2014-10-31 23:19 Alexandra Yates
2014-11-01 9:06 SF Markus Elfring
2014-11-01 10:52 Magnus Fromreide
2014-11-01 12:00 SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5442C936.3000303@users.sourceforge.net \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.