From: Jiri Slaby <jirislaby@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: <linux-kernel@vger.kernel.org>, <p.hardwick@option.com>
Subject: [PATCH 2/2] Char: nozomi, bad comment sings
Date: Sat, 7 Oct 2006 01:54:07 +0200 (CEST) [thread overview]
Message-ID: <54435213243213@wsc.cz> (raw)
nozomi, bad comment sings
Don't use // for comments in C.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
commit 3cbc3a3dd48ae68c4a936d161e5f256094fc2bef
tree 529c5a4b7efcda99629b09c744bc63852762cd6e
parent e7e58c9f0d3ce7bed7f8c4b1921da37d65e3ee8f
author Jiri Slaby <jirislaby@gmail.com> Sat, 07 Oct 2006 01:49:54 +0200
committer Jiri Slaby <xslaby@anemoi.localdomain> Sat, 07 Oct 2006 01:49:54 +0200
drivers/char/nozomi.c | 28 ++++++++++++++--------------
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/char/nozomi.c b/drivers/char/nozomi.c
index 354a8a6..70ac4ac 100644
--- a/drivers/char/nozomi.c
+++ b/drivers/char/nozomi.c
@@ -413,11 +413,11 @@ struct port {
ctrl_ul_t ctrl_ul;
ctrl_dl_t ctrl_dl;
struct kfifo *fifo_ul;
-// u32 dl_addr[2];
+/* u32 dl_addr[2]; */
void __iomem *dl_addr[2];
u32 dl_size[2];
u8 toggle_dl;
-// u32 ul_addr[2];
+/* u32 ul_addr[2]; */
void __iomem *ul_addr[2];
u32 ul_size[2];
u8 toggle_ul;
@@ -435,7 +435,7 @@ struct port {
/* Private data one for each card in the system */
typedef struct {
-// u32 base_addr;
+/* u32 base_addr; */
void __iomem *base_addr;
u8 closing;
@@ -519,7 +519,7 @@ static inline dc_t *get_dc_by_tty(struct
/* TODO: */
/* -Optimize */
/* -Rewrite cleaner */
-//static void read_mem32(u32 *buf, u32 mem_addr_start, u32 size_bytes) {
+/*static void read_mem32(u32 *buf, u32 mem_addr_start, u32 size_bytes) { */
static void read_mem32(u32 * buf, void __iomem * mem_addr_start, u32 size_bytes)
{
u32 i = 0;
@@ -552,7 +552,7 @@ static void read_mem32(u32 * buf, void _
/* TODO: */
/* - Rewrite cleaner */
/* - merge with read_mem32() */
-//static void read_mem32_buf(u32 *buf, u32 mem_addr_start, u32 size_bytes) {
+/*static void read_mem32_buf(u32 *buf, u32 mem_addr_start, u32 size_bytes) { */
static void read_mem32_buf(u32 * buf, void __iomem * mem_addr_start,
u32 size_bytes)
{
@@ -590,7 +590,7 @@ #endif
/* TODO: */
/* -Optimize */
/* -Rewrite cleaner */
-//static u32 write_mem32(u32 mem_addr_start, u32 *buf, u32 size_bytes) {
+/*static u32 write_mem32(u32 mem_addr_start, u32 *buf, u32 size_bytes) {*/
static u32 write_mem32(void __iomem * mem_addr_start, u32 * buf, u32 size_bytes)
{
u32 i = 0;
@@ -623,7 +623,7 @@ static u32 write_mem32(void __iomem * me
/* Todo: */
/* - Merge with write_mem32() */
-//static u32 write_mem32_buf(u32 mem_addr_start, u32 *buf, u32 size_bytes) {
+/*static u32 write_mem32_buf(u32 mem_addr_start, u32 *buf, u32 size_bytes) {*/
static u32 write_mem32_buf(void __iomem * mem_addr_start, u32 * buf,
u32 size_bytes)
{
@@ -738,7 +738,7 @@ static void setup_memory(dc_t * dc)
dc->config_table.ul_app2_len);
dc->port[PORT_CTRL].ul_size[CH_A] =
dc->config_table.ul_ctrl_len - buff_offset;
-// offset = dc->config_table.ul_start;
+/* offset = dc->config_table.ul_start;*/
}
/* Dump config table under initalization phase */
@@ -1852,7 +1852,7 @@ static int ntty_write(struct tty_struct
}
spin_lock_irqsave(&dc->spin_mutex, flags);
- // CTS is only valid on the modem channel
+ /* CTS is only valid on the modem channel */
if (port == &(dc->port[PORT_MDM])) {
if (port->ctrl_dl.CTS) {
D4("Enable interrupt");
@@ -1878,8 +1878,8 @@ static int ntty_write_room(struct tty_st
{
struct port *port = (struct port *)tty->driver_data;
int room = 0;
-// u32 flags = 0;
-// dc_t *dc = get_dc_by_tty(tty);
+/* u32 flags = 0;
+ dc_t *dc = get_dc_by_tty(tty); */
if (!port) {
return 0;
@@ -1887,9 +1887,9 @@ static int ntty_write_room(struct tty_st
if (down_trylock(&port->tty_sem)) {
return 0;
}
-// if(down_interruptible(&port->tty_sem)){
-// return 0;
-// }
+/* if(down_interruptible(&port->tty_sem)) {
+ return 0;
+ }*/
if (!port->tty_open_count) {
goto exit;
next reply other threads:[~2006-10-06 23:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 23:54 Jiri Slaby [this message]
2006-10-08 18:26 ` [PATCH 2/2] Char: nozomi, bad comment sings Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54435213243213@wsc.cz \
--to=jirislaby@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.hardwick@option.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.