From: Giedrius Statkevicius <giedrius.statkevicius@gmail.com>
To: Fabio Falzoi <fabio.falzoi84@gmail.com>, gregkh@linuxfoundation.org
Cc: micky_ching@realsil.com.cn, joe@perches.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Staging: rts5208: rtsx_reset_chip style clean up
Date: Sun, 19 Oct 2014 13:48:51 +0300 [thread overview]
Message-ID: <54439713.7020907@gmail.com> (raw)
In-Reply-To: <1413712554-4872-1-git-send-email-fabio.falzoi84@gmail.com>
On 2014.10.19 12:55, Fabio Falzoi wrote:
> Clean up the code in rtsx_reset_chip function defining two new helper
> functions rtsx_reset_aspm and rtsx_enable_pcie_intr.
> Specifically, the following checkpatch warnings are corrected:
> * PARENTHESIS_ALIGNMENT at rows 271, 302, 343 and 346
> * LONG_LINE at rows 294, 313 and 315
> * BRACES at rowa 320 and 351
> This patch is inspired by the following post on LKML regarding another
> clean up for rts5208 module:
> http://www.spinics.net/lists/linux-driver-devel/msg55038.html
>
> Fabio Falzoi (2):
> Staging: rts5208: helper function to manage aspm during reset
> Staging: rts5208: helper function to enable interrupts during reset
>
> drivers/staging/rts5208/rtsx_chip.c | 168 +++++++++++++++++++-----------------
> 1 file changed, 87 insertions(+), 81 deletions(-)
>
Could you please remake this patch set against the staging-testing
branch?
https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/?h=staging-testing&id=ccf2d2456648ce84090ea1f37bd6774bafa99f00
This will break your patch on staging-testing.
prev parent reply other threads:[~2014-10-19 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 9:55 [PATCH 0/2] Staging: rts5208: rtsx_reset_chip style clean up Fabio Falzoi
2014-10-19 9:55 ` [PATCH 1/2] Staging: rts5208: helper function to manage aspm during reset Fabio Falzoi
2014-10-19 9:55 ` [PATCH 2/2] Staging: rts5208: helper function to enable interrupts " Fabio Falzoi
2014-10-19 10:48 ` Giedrius Statkevicius [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54439713.7020907@gmail.com \
--to=giedrius.statkevicius@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.falzoi84@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.