From: SF Markus Elfring <elfring at users.sourceforge.net>
To: powertop@lists.01.org
Subject: Re: [Powertop] Complete build options for Pthread API
Date: Sun, 19 Oct 2014 13:30:18 +0200 [thread overview]
Message-ID: <5443A0CA.1010506@users.sourceforge.net> (raw)
In-Reply-To: alpine.LNX.2.03.1410182355460.12471@iki.fi
[-- Attachment #1: Type: text/plain, Size: 789 bytes --]
> I suppose you mean change about like this.
Yes. - Your approach comes very close to my imaginations.
I suggest to reconsider a few implementation details there.
> The macro figures out how to build C programs using POSIX threads, and
> the PTHREAD_CFLAGS output variable to any special C compiler flags that
> are needed.
1. How do you think about to mention in your commit message that three
variables (including "LIBS") will be adjusted eventually?
> +AX_PTHREAD([], [AC_MSG_ERROR([Could not configure pthreads support])])
2. You chose to pass an empty "ACTION-IF-FOUND". Would it make sense to
restructure this place a bit in the configuration script so that the
following statements will be directly used by the first macro parameter?
Regards,
Markus
next reply other threads:[~2014-10-19 11:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 11:30 SF Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-11-01 8:15 [Powertop] Complete build options for Pthread API SF Markus Elfring
2014-10-31 18:01 Alexandra Yates
2014-10-31 10:20 SF Markus Elfring
2014-10-31 10:01 Sami Kerola
2014-10-31 3:35 Alexandra Yates
2014-10-31 2:34 Alexandra Yates
2014-10-25 10:18 Sami Kerola
2014-10-25 8:58 Sergey Senozhatsky
2014-10-22 14:33 Sami Kerola
2014-10-22 12:41 Sergey Senozhatsky
2014-10-22 9:41 Sami Kerola
2014-10-20 4:44 SF Markus Elfring
2014-10-19 18:18 Sami Kerola
2014-10-18 22:57 Sami Kerola
2014-10-18 19:20 SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5443A0CA.1010506@users.sourceforge.net \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.