From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Sune Subject: Re: "TX WTHRESH must be set to 0 if tx_rs_thresh is greater than 1" Date: Sun, 19 Oct 2014 15:46:27 +0200 Message-ID: <5443C0B3.6060805@bisdn.de> References: <20141018225002.GA17115@mhcomputing.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <20141018225002.GA17115-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Which DPDK version are you using marc On 19/10/14 00:50, Matthew Hall wrote: > Hello, > > I'm just trying to understand what you're supposed to do about this error to > get the optiomal configuration / performance. The error message and comments > seem like they're designed for Intel ethernet driver hackers not security > hackers like myself! ;-) > > Note: I'm trying out the Intel 82545EM in VirtualBox because the virtio-net > approach didn't work, for reasons I enumerated in some previous mails. > > /* > * If rs_bit_thresh is greater than 1, then TX WTHRESH should be > * set to 0. If WTHRESH is greater than zero, the RS bit is ignored > * by the NIC and all descriptors are written back after the NIC > * accumulates WTHRESH descriptors. > */ > if (tx_conf->tx_thresh.wthresh != 0 && tx_rs_thresh != 1) { > RTE_LOG(ERR, PMD, "TX WTHRESH must be set to 0 if " > "tx_rs_thresh is greater than 1. (tx_rs_thresh=%u " > "port=%d queue=%d)\n", (unsigned int)tx_rs_thresh, > (int)dev->data->port_id, (int)queue_idx); > return -(EINVAL); > } > > Thanks, > Matthew.