All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Rohit Athavale <rohit.athavale@xilinx.com>
Cc: linux-media@vger.kernel.org, hyun.kwon@xilinx.com,
	Rohit Athavale <rathaval@xilinx.com>
Subject: Re: [PATCH 3/3] Documentation: subdev-formats: Add Xilinx YCbCr to Vendor specific area
Date: Fri, 18 Aug 2017 12:18:03 +0300	[thread overview]
Message-ID: <5444997.CSWZR4Ez4Z@avalon> (raw)
In-Reply-To: <1502303274-40609-4-git-send-email-rathaval@xilinx.com>

Hi Rohit,

Thank you for the patch.

On Wednesday 09 Aug 2017 11:27:54 Rohit Athavale wrote:
> This commit adds the custom Xilinx IP specific 8-bit YCbCr 4:2:0
> to the custom formats area in the subdev-formats documentation.
> 
> Signed-off-by: Rohit Athavale <rathaval@xilinx.com>
> ---
>  Documentation/media/uapi/v4l/subdev-formats.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/media/uapi/v4l/subdev-formats.rst
> b/Documentation/media/uapi/v4l/subdev-formats.rst index 8e73bb0..141a837
> 100644
> --- a/Documentation/media/uapi/v4l/subdev-formats.rst
> +++ b/Documentation/media/uapi/v4l/subdev-formats.rst
> @@ -7483,3 +7483,8 @@ formats.
>        - 0x5001
>        - Interleaved raw UYVY and JPEG image format with embedded meta-data
>  	used by Samsung S3C73MX camera sensors.
> +    * .. _MEDIA_BUS_FMT_XLNX8_VUY420_1X24:
> +
> +      - MEDIA_BUS_FMT_XLNX8_VUY420_1X24
> +      - 0x5002
> +      - Xilinx IP specific 8-bit color depth YCbCr 4:2:0 used by Xilinx
> Video IP.

You need to document this format in more details, with a table explaining how 
bits are transferred on the bus, the same way the standard YUV formats are 
documented.

-- 
Regards,

Laurent Pinchart

      reply	other threads:[~2017-08-18  9:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09 18:27 [PATCH 0/3] Xilinx 8-bit color depth YCbCr 4:2:0 media bus format Rohit Athavale
2017-08-09 18:27 ` [PATCH 1/3] uapi: media-bus-format: Add Xilinx specific " Rohit Athavale
2017-08-18  9:17   ` Laurent Pinchart
2017-08-09 18:27 ` [PATCH 2/3] media: xilinx-vip: Add 8-bit YCbCr 4:2:0 to formats table Rohit Athavale
2017-08-18  9:16   ` Laurent Pinchart
2017-08-09 18:27 ` [PATCH 3/3] Documentation: subdev-formats: Add Xilinx YCbCr to Vendor specific area Rohit Athavale
2017-08-18  9:18   ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5444997.CSWZR4Ez4Z@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=hyun.kwon@xilinx.com \
    --cc=linux-media@vger.kernel.org \
    --cc=rathaval@xilinx.com \
    --cc=rohit.athavale@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.