From: Eric Blake <eblake@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, armbru@redhat.com, aliguori@amazon.com
Subject: Re: [Qemu-devel] [PATCH v2 2/2] vl.c: reduce exit on error code duplication
Date: Mon, 20 Oct 2014 10:48:45 -0600 [thread overview]
Message-ID: <54453CED.40708@redhat.com> (raw)
In-Reply-To: <1413808195-7428-3-git-send-email-imammedo@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
On 10/20/2014 06:29 AM, Igor Mammedov wrote:
> use error_report_fatal() helper instead of a bunch of
> if (local_err) {
> error_report(foo);
> error_free(local_err);
> exit(1);
> }
> code blocks
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> * s/exit_if_error/error_report_fatal/
> * move error_report_fatal() into util/error.c
> ---
> include/qemu/error-report.h | 2 ++
> util/error.c | 24 ++++++++++++++++++++++++
> vl.c | 34 ++++++----------------------------
> 3 files changed, 32 insertions(+), 28 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
prev parent reply other threads:[~2014-10-20 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 12:29 [Qemu-devel] [PATCH v2 0/2] vl.c: unify exit on error handling Igor Mammedov
2014-10-20 12:29 ` [Qemu-devel] [PATCH v2 1/2] vl.c: use single local_err throughout main() Igor Mammedov
2014-10-20 12:29 ` [Qemu-devel] [PATCH v2 2/2] vl.c: reduce exit on error code duplication Igor Mammedov
2014-10-20 16:48 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54453CED.40708@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.