From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH] tty: serial: msm: Fix lock init issue with earlycon Date: Mon, 20 Oct 2014 11:27:02 -0700 Message-ID: <544553F6.1020409@codeaurora.org> References: <1413551588-14877-1-git-send-email-galak@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.11.231]:39792 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbaJTS1F (ORCPT ); Mon, 20 Oct 2014 14:27:05 -0400 In-Reply-To: <1413551588-14877-1-git-send-email-galak@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Kumar Gala Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-arm-msm , linux-arm-kernel@lists.infradead.org, Rob Herring On 10/17/2014 06:13 AM, Kumar Gala wrote: > With CONFIG_DEBUG_SPINLOCK enabled we see: > > BUG: spinlock bad magic on CPU#0, swapper/0 > lock: early_console_dev+0x8/0x160, .magic: 00000000, .owner: /-1, .owner_cpu: 0 > CPU: 0 PID: 0 Comm: swapper Not tainted 3.17.0-09733-gb446b33-dirty #18 [...] > diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c > index 4b6c783..8ab27c9 100644 > --- a/drivers/tty/serial/msm_serial.c > +++ b/drivers/tty/serial/msm_serial.c > @@ -973,6 +973,8 @@ msm_serial_early_console_setup(struct earlycon_device *device, const char *opt) > if (!device->port.membase) > return -ENODEV; > > + spin_lock_init(&device->port.lock); > + > device->con->write = msm_serial_early_write; > return 0; > } > @@ -995,6 +997,8 @@ msm_serial_early_console_setup_dm(struct earlycon_device *device, > if (!device->port.membase) > return -ENODEV; > > + spin_lock_init(&device->port.lock); > + > device->con->write = msm_serial_early_write_dm; > return 0; > } Could this be done in the tty core instead? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@codeaurora.org (Stephen Boyd) Date: Mon, 20 Oct 2014 11:27:02 -0700 Subject: [PATCH] tty: serial: msm: Fix lock init issue with earlycon In-Reply-To: <1413551588-14877-1-git-send-email-galak@codeaurora.org> References: <1413551588-14877-1-git-send-email-galak@codeaurora.org> Message-ID: <544553F6.1020409@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/17/2014 06:13 AM, Kumar Gala wrote: > With CONFIG_DEBUG_SPINLOCK enabled we see: > > BUG: spinlock bad magic on CPU#0, swapper/0 > lock: early_console_dev+0x8/0x160, .magic: 00000000, .owner: /-1, .owner_cpu: 0 > CPU: 0 PID: 0 Comm: swapper Not tainted 3.17.0-09733-gb446b33-dirty #18 [...] > diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c > index 4b6c783..8ab27c9 100644 > --- a/drivers/tty/serial/msm_serial.c > +++ b/drivers/tty/serial/msm_serial.c > @@ -973,6 +973,8 @@ msm_serial_early_console_setup(struct earlycon_device *device, const char *opt) > if (!device->port.membase) > return -ENODEV; > > + spin_lock_init(&device->port.lock); > + > device->con->write = msm_serial_early_write; > return 0; > } > @@ -995,6 +997,8 @@ msm_serial_early_console_setup_dm(struct earlycon_device *device, > if (!device->port.membase) > return -ENODEV; > > + spin_lock_init(&device->port.lock); > + > device->con->write = msm_serial_early_write_dm; > return 0; > } Could this be done in the tty core instead? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project