From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v3 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions Date: Mon, 20 Oct 2014 23:47:40 +0200 Message-ID: <544582FC.9010005@collabora.co.uk> References: <1413839151-10875-1-git-send-email-javier.martinez@collabora.co.uk> <1413839151-10875-3-git-send-email-javier.martinez@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from bhuna.collabora.co.uk ([93.93.135.160]:40409 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751233AbaJTVrp (ORCPT ); Mon, 20 Oct 2014 17:47:45 -0400 In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Doug Anderson Cc: Kukjin Kim , Mark Brown , Tomasz Figa , Chanwoo Choi , linux-samsung-soc , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Hello Doug, On 10/20/2014 11:40 PM, Doug Anderson wrote: > Javier, > > On Mon, Oct 20, 2014 at 2:05 PM, Javier Martinez Canillas > wrote: >> The regulator framework has a set of helpers functions to be used when >> the system is entering and leaving from suspend but these are not called >> on Exynos platforms. This means that the .set_suspend_* function handlers >> defined by regulator drivers are not called when the system is suspended. >> >> Suggested-by: Doug Anderson >> Signed-off-by: Javier Martinez Canillas >> Reviewed-by: Doug Anderson > > I think you forgot to carry Chanwoo's review: > > Reviewed-by: Chanwoo Choi > > I don't think you've made any changes that would need to invalidate his review. > Yes, I forgot to add the tag to my local branch so it was missed when generating the patch for the new version, sorry about that... Best regards, Javier From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier.martinez@collabora.co.uk (Javier Martinez Canillas) Date: Mon, 20 Oct 2014 23:47:40 +0200 Subject: [PATCH v3 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions In-Reply-To: References: <1413839151-10875-1-git-send-email-javier.martinez@collabora.co.uk> <1413839151-10875-3-git-send-email-javier.martinez@collabora.co.uk> Message-ID: <544582FC.9010005@collabora.co.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Doug, On 10/20/2014 11:40 PM, Doug Anderson wrote: > Javier, > > On Mon, Oct 20, 2014 at 2:05 PM, Javier Martinez Canillas > wrote: >> The regulator framework has a set of helpers functions to be used when >> the system is entering and leaving from suspend but these are not called >> on Exynos platforms. This means that the .set_suspend_* function handlers >> defined by regulator drivers are not called when the system is suspended. >> >> Suggested-by: Doug Anderson >> Signed-off-by: Javier Martinez Canillas >> Reviewed-by: Doug Anderson > > I think you forgot to carry Chanwoo's review: > > Reviewed-by: Chanwoo Choi > > I don't think you've made any changes that would need to invalidate his review. > Yes, I forgot to add the tag to my local branch so it was missed when generating the patch for the new version, sorry about that... Best regards, Javier