From: Prarit Bhargava <prarit@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] scripts, checkpatch.pl, provide a better output message for commit id format [v2]
Date: Mon, 20 Oct 2014 20:46:59 -0400 [thread overview]
Message-ID: <5445AD03.6000901@redhat.com> (raw)
In-Reply-To: <1413846680.5407.4.camel@perches.com>
On 10/20/2014 07:11 PM, Joe Perches wrote:
> On Mon, 2014-10-20 at 18:49 -0400, Prarit Bhargava wrote:
>> I tested this using both lower and upper case 'c' with the following commit
>> text:
> []
>
> I think the patch subject be something like:
>
> "[PATCH] checkpatch: improve commit id/desc style checking in commit message"
>
> The [v2] goes in the subject like this:
>
> "[PATCH V2] checkpatch: ..."
>
>> 11 chars, SHOULD FAIL
>> commit 1234567890a
>
> []
>
>> ERROR: Please use 12 or more chars for the git commit ID
>> commit 1234567890a
>
> I'd expect these messages to mention something about the
> missing commit description too.
Hmm ... is that a requirement here? Currently checkpatch.pl doesn't complain
about that. I can do it but I'd hate to find out that I'm ERRORing on something
that is considered okay to do.
P.
>
>
next prev parent reply other threads:[~2014-10-21 0:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 22:49 [PATCH] scripts, checkpatch.pl, provide a better output message for commit id format [v2] Prarit Bhargava
2014-10-20 23:11 ` Joe Perches
2014-10-21 0:46 ` Prarit Bhargava [this message]
2014-10-21 2:11 ` Joe Perches
2014-10-21 12:03 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5445AD03.6000901@redhat.com \
--to=prarit@redhat.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.