From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH v2 04/12] scsi_tcq.h: Add support for multiple hardware queues Date: Tue, 21 Oct 2014 11:59:27 +0300 Message-ID: <5446206F.7020401@dev.mellanox.co.il> References: <5433E43D.3010107@acm.org> <5433E4C4.4030104@acm.org> <5443E2DF.1040605@dev.mellanox.co.il> <5444F995.5080407@acm.org> <20141021084952.GC10407@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141021084952.GC10407@infradead.org> Sender: linux-scsi-owner@vger.kernel.org To: Christoph Hellwig , Bart Van Assche Cc: Jens Axboe , Sagi Grimberg , Sebastian Parschauer , Robert Elliott , Ming Lei , "linux-scsi@vger.kernel.org" , linux-rdma List-Id: linux-rdma@vger.kernel.org On 10/21/2014 11:49 AM, Christoph Hellwig wrote: > On Mon, Oct 20, 2014 at 02:01:25PM +0200, Bart Van Assche wrote: >> On 10/19/14 18:12, Sagi Grimberg wrote: >>> On 10/7/2014 4:04 PM, Bart Van Assche wrote: >>>> - req = blk_queue_find_tag(sdev->request_queue, tag); >>>> + req = blk_queue_find_tag(sdev->request_queue, tag); >>> >>> Why is this line different? >> >> This is because the indentation has been modified from "8x" into >> "". I can leave out that change if you want. > > Please keep it. > I don't have a big objection on this, but the problem with leaving this stuff is that it tends to screw up git blame...