From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH for 4.5 v7 1/1] Add mmio_hole_size Date: Tue, 21 Oct 2014 08:58:52 -0400 Message-ID: <5446588C.1080202@terremark.com> References: <1413204679-7345-1-git-send-email-dslutz@verizon.com> <1413204679-7345-2-git-send-email-dslutz@verizon.com> <1413814677.13796.10.camel@citrix.com> <54458621.3080102@terremark.com> <54462B6802000078000408A0@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54462B6802000078000408A0@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Don Slutz Cc: Ian Campbell , Stefano Stabellini , Ian Jackson , xen-devel@lists.xen.org, Boris Ostrovsky List-Id: xen-devel@lists.xenproject.org On 10/21/14 03:46, Jan Beulich wrote: >>>> On 21.10.14 at 00:01, wrote: >> On 10/20/14 10:17, Ian Campbell wrote: >>>> + /* >>>> + * With HVM_BELOW_4G_RAM_END == 0xF0000000, mmio_hole_size >>>> + * must be >= 256 MiB and <= 3840 MiB. >>> Isn't this just restating the if condition in a way which is liable to >>> get out of sync if the values of HVM_BELOW_4G_* ever changes? >> Well, Konrad asked for this: >> [...] >> So I do not know which way to go here. > I have to admit that I think Konrad is asking for too much commentary > now and then. But in any event - Ian being one of the maintainers of > the affected code, what he asks you to do generally overrules what > any non-maintainer may have asked for. Thanks for this. Sent v8. -Don Slutz > Jan >