All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wanpeng Li <kernellwp@gmail.com>
To: Juri Lelli <juri.lelli@arm.com>,
	Wanpeng Li <wanpeng.li@linux.intel.com>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] sched/deadline: don't need to balance during wakeup if wakee is pinned
Date: Tue, 21 Oct 2014 21:39:26 +0800	[thread overview]
Message-ID: <5446620E.4020700@gmail.com> (raw)
In-Reply-To: <54465FB6.1060800@arm.com>

Hi Juri,

于 10/21/14, 9:29 PM, Juri Lelli 写道:
> Hi,
>
> On 21/10/14 13:19, Wanpeng Li wrote:
>> Cc Juri,
>>
>> 于 10/14/14, 10:22 AM, Wanpeng Li 写道:
>>> Use nr_cpus_allowed to bail from select_task_rq() when only one cpu
>>> can be used, and saves some cycles for pinned tasks.
>>>
>>> Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
>>> ---
>>>   kernel/sched/deadline.c | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
>>> index f46b7f1..5874bf8 100644
>>> --- a/kernel/sched/deadline.c
>>> +++ b/kernel/sched/deadline.c
>>> @@ -914,6 +914,9 @@ select_task_rq_dl(struct task_struct *p, int cpu, int sd_flag, int flags)
>>>   	struct task_struct *curr;
>>>   	struct rq *rq;
>>>   
>>> +	if (p->nr_cpus_allowed == 1)
>>> +		goto out;
>>> +
>>>   	if (sd_flag != SD_BALANCE_WAKE)
>>>   		goto out;
>>>
> Apart from the encoding of the resend, it looks good, thanks!

What's your meaning of resend? Do you mean this one?

https://lkml.org/lkml/2014/10/10/425

I'm afraid they are different patches.

Regards,
Wanpeng Li

>
> Best,
>
> - Juri
>


  reply	other threads:[~2014-10-21 13:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-14  2:22 [PATCH 1/2] sched/deadline: don't need to check SD_BALANCE_FORK Wanpeng Li
2014-10-14  2:22 ` [PATCH 2/2] sched/deadline: don't need to balance during wakeup if wakee is pinned Wanpeng Li
2014-10-21 12:19   ` Wanpeng Li
2014-10-21 13:29     ` Juri Lelli
2014-10-21 13:39       ` Wanpeng Li [this message]
2014-10-21 13:42         ` Juri Lelli
2014-10-28 11:07   ` [tip:sched/core] sched/deadline: Don' t " tip-bot for Wanpeng Li
2014-10-21 12:18 ` [PATCH 1/2] sched/deadline: don't need to check SD_BALANCE_FORK Wanpeng Li
2014-10-21 13:38   ` Juri Lelli
2014-10-28 11:07 ` [tip:sched/core] sched/deadline: Don't " tip-bot for Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5446620E.4020700@gmail.com \
    --to=kernellwp@gmail.com \
    --cc=juri.lelli@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=wanpeng.li@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.