From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Tue, 21 Oct 2014 16:18:34 +0200 Subject: [PATCH] power: reset: at91-reset: fix power down register In-Reply-To: <1413829629-8705-1-git-send-email-alexandre.belloni@free-electrons.com> References: <1413829629-8705-1-git-send-email-alexandre.belloni@free-electrons.com> Message-ID: <54466B3A.5030005@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 20/10/2014 20:27, Alexandre Belloni : > In the case of at91sam9g45_restart(), the driver is writing > AT91_DDRSDRC_LPCB_POWER_DOWN to AT91_DDRSDRC_RTR, this should actually be > AT91_DDRSDRC_LPR. > > Signed-off-by: Alexandre Belloni Absolutely: Acked-by: Nicolas Ferre If you don't mind Dmitry, I'll take this patch through the at91/arm-soc git trees in my next at91-3.18-fixes branch. Thanks Alex, bye, > --- > drivers/power/reset/at91-reset.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c > index 3611806c9cfd..3cb36693343a 100644 > --- a/drivers/power/reset/at91-reset.c > +++ b/drivers/power/reset/at91-reset.c > @@ -100,11 +100,11 @@ static void at91sam9g45_restart(enum reboot_mode mode, const char *cmd) > /* Disable SDRAM0 accesses */ > "1: str %3, [%0, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t" > /* Power down SDRAM0 */ > - " str %4, [%0, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t" > + " str %4, [%0, #" __stringify(AT91_DDRSDRC_LPR) "]\n\t" > /* Disable SDRAM1 accesses */ > " strne %3, [%1, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t" > /* Power down SDRAM1 */ > - " strne %4, [%1, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t" > + " strne %4, [%1, #" __stringify(AT91_DDRSDRC_LPR) "]\n\t" > /* Reset CPU */ > " str %5, [%2, #" __stringify(AT91_RSTC_CR) "]\n\t" > > -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932960AbaJUOSm (ORCPT ); Tue, 21 Oct 2014 10:18:42 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:49048 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932711AbaJUOSl (ORCPT ); Tue, 21 Oct 2014 10:18:41 -0400 Message-ID: <54466B3A.5030005@atmel.com> Date: Tue, 21 Oct 2014 16:18:34 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Alexandre Belloni , "Dmitry Eremin-Solenikov" , David Woodhouse CC: Jean-Christophe Plagniol-Villard , Maxime Ripard , Boris Brezillon , , Subject: Re: [PATCH] power: reset: at91-reset: fix power down register References: <1413829629-8705-1-git-send-email-alexandre.belloni@free-electrons.com> In-Reply-To: <1413829629-8705-1-git-send-email-alexandre.belloni@free-electrons.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/10/2014 20:27, Alexandre Belloni : > In the case of at91sam9g45_restart(), the driver is writing > AT91_DDRSDRC_LPCB_POWER_DOWN to AT91_DDRSDRC_RTR, this should actually be > AT91_DDRSDRC_LPR. > > Signed-off-by: Alexandre Belloni Absolutely: Acked-by: Nicolas Ferre If you don't mind Dmitry, I'll take this patch through the at91/arm-soc git trees in my next at91-3.18-fixes branch. Thanks Alex, bye, > --- > drivers/power/reset/at91-reset.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c > index 3611806c9cfd..3cb36693343a 100644 > --- a/drivers/power/reset/at91-reset.c > +++ b/drivers/power/reset/at91-reset.c > @@ -100,11 +100,11 @@ static void at91sam9g45_restart(enum reboot_mode mode, const char *cmd) > /* Disable SDRAM0 accesses */ > "1: str %3, [%0, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t" > /* Power down SDRAM0 */ > - " str %4, [%0, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t" > + " str %4, [%0, #" __stringify(AT91_DDRSDRC_LPR) "]\n\t" > /* Disable SDRAM1 accesses */ > " strne %3, [%1, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t" > /* Power down SDRAM1 */ > - " strne %4, [%1, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t" > + " strne %4, [%1, #" __stringify(AT91_DDRSDRC_LPR) "]\n\t" > /* Reset CPU */ > " str %5, [%2, #" __stringify(AT91_RSTC_CR) "]\n\t" > > -- Nicolas Ferre