From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] omap3/am33xx: mux: fix several checkpatch issues
Date: Tue, 21 Oct 2014 17:36:11 +0200 [thread overview]
Message-ID: <54467D6B.2080404@denx.de> (raw)
In-Reply-To: <1413905130-26930-1-git-send-email-grinberg@compulab.co.il>
On 21.10.2014 17:25, Igor Grinberg wrote:
> Fix the following checkpatch issues:
>
> CHECK: No space is necessary after a cast
> \#39: FILE: arch/arm/include/asm/arch-am33xx/mux.h:39:
> +#define PAD_CTRL_BASE 0x800
> +#define OFFSET(x) (unsigned int) (&((struct pad_signals *) \
>
> CHECK: Avoid CamelCase: <CONTROL_PADCONF_JTAG_nTRST>
> \#284: FILE: arch/arm/include/asm/arch-omap3/mux.h:284:
> +#define CONTROL_PADCONF_JTAG_nTRST 0x0A1C
>
> ERROR: space required after that ',' (ctx:VxV)
> \#446: FILE: arch/arm/include/asm/arch-omap3/mux.h:446:
> +#define MUX_VAL(OFFSET,VALUE)\
> ^
> Cc: Raphael Assenat <raph@8d.com>
> Cc: Ilya Yanok <yanok@emcraft.com>
> Cc: Vaibhav Hiremath <hvaibhav@ti.com>
> Cc: Peter Barada <peter.barada@logicpd.com>
> Cc: Grazvydas Ignotas <notasas@gmail.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Nagendra T S <nagendra@mistralsolutions.com>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Tom Rini <trini@ti.com>
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
Looks good, so:
Acked-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
next prev parent reply other threads:[~2014-10-21 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 15:25 [U-Boot] [PATCH] omap3/am33xx: mux: fix several checkpatch issues Igor Grinberg
2014-10-21 15:36 ` Stefan Roese [this message]
2014-10-23 17:17 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54467D6B.2080404@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.