From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH] ASoC: tegra: Read and use the GPIO flags of the headphone detect Date: Tue, 21 Oct 2014 10:14:41 -0600 Message-ID: <54468671.7060000@wwwdotorg.org> References: <1413905609-23268-1-git-send-email-alban.bedel@avionic-design.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1413905609-23268-1-git-send-email-alban.bedel-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alban Bedel , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Thierry Reding , Alexandre Courbot , Lars-Peter Clausen , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: alsa-devel@alsa-project.org On 10/21/2014 09:33 AM, Alban Bedel wrote: > The headphone detect was hardcoded to low-active, use the flags from > DT to allow high-active as well. > diff --git a/sound/soc/tegra/tegra_rt5640.c b/sound/soc/tegra/tegra_rt5640.c > @@ -44,6 +44,7 @@ > struct tegra_rt5640 { > struct tegra_asoc_utils_data util_data; > int gpio_hp_det; > + enum of_gpio_flags gpio_hp_det_flags; I have no idea why that's an enum if it's meant to be interpreted as a bit mask, but that's an issue with of_gpio.h, not this patch. Acked-by: Stephen Warren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755957AbaJUQOW (ORCPT ); Tue, 21 Oct 2014 12:14:22 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:49830 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755659AbaJUQOV (ORCPT ); Tue, 21 Oct 2014 12:14:21 -0400 Message-ID: <54468671.7060000@wwwdotorg.org> Date: Tue, 21 Oct 2014 10:14:41 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Alban Bedel , linux-kernel@vger.kernel.org CC: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Thierry Reding , Alexandre Courbot , Lars-Peter Clausen , alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] ASoC: tegra: Read and use the GPIO flags of the headphone detect References: <1413905609-23268-1-git-send-email-alban.bedel@avionic-design.de> In-Reply-To: <1413905609-23268-1-git-send-email-alban.bedel@avionic-design.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/21/2014 09:33 AM, Alban Bedel wrote: > The headphone detect was hardcoded to low-active, use the flags from > DT to allow high-active as well. > diff --git a/sound/soc/tegra/tegra_rt5640.c b/sound/soc/tegra/tegra_rt5640.c > @@ -44,6 +44,7 @@ > struct tegra_rt5640 { > struct tegra_asoc_utils_data util_data; > int gpio_hp_det; > + enum of_gpio_flags gpio_hp_det_flags; I have no idea why that's an enum if it's meant to be interpreted as a bit mask, but that's an issue with of_gpio.h, not this patch. Acked-by: Stephen Warren