Re: [PATCH] hid: Add mapping for special keys on compaq ku 0133 keyboard

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 08/13/2014 01:35 AM, Dmitry Torokhov wrote:
> On Wed, Aug 13, 2014 at 01:14:50AM +0200, Hans de Goede wrote:
>> The compaq ku 0133 keyboard has 8 special keys at the top:
>> http://lackof.org/taggart/hacking/keyboard/cpqwireless.jpg
>>
>> 3 of these use standard HID usage codes from the consumer page, the 5
>> others use part of the reserved 0x07 - 0x1f range.
>>
>> This commit adds mapping for this keyboard for these reserved codes, making
>> the other 5 keys work.
>
> Can't we just load the proper keymap through udev without writing yet another
> kernel driver?

A valid question, and I agree that in this case where no special handling is
necessary, that would be better. So I've just tried this, but this does not
work, because hid-input.c chooses to ignore unknown usage codes in the
consumer page, rather then map them to KEY_UNKNOWN, making it impossible
to remap them through udev/hwdb later.

I've written a patch to fix this +  a hwdb patch, which seems like a better
way to deal with this then my original patch introducing a compaq usb hid kernel
driver esp. for this.

Regards,

Hans