From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42703)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XgqoO-0008Mt-TM
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 03:58:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XgqoJ-0000oy-EX
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 03:58:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59381)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XgqoJ-0000op-6c
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 03:58:23 -0400
Message-ID: <54476397.3020808@redhat.com>
Date: Wed, 22 Oct 2014 09:58:15 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1413891300-23369-1-git-send-email-mst@redhat.com>	<20141022072204.GA28193@redhat.com>
	<877fzsk0ku.fsf@blackfin.pond.sub.org>
In-Reply-To: <877fzsk0ku.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] scripts/get_maintainer.pl: allow "odd
	fixes"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>



On 10/22/2014 09:47 AM, Markus Armbruster wrote:
> Like this:
> 
>     $ scripts/get_maintainer.pl -f --no-git-fallback hw/ide/core.c 
>     Kevin Wolf <kwolf@redhat.com> (odd fixer:IDE)
>     Stefan Hajnoczi <stefanha@redhat.com> (odd fixer:IDE)
> 
> What's wrong with that?

Michael's patch fixes the case where you do _not_ have --no-git-fallback:

    $ scripts/get_maintainer.pl -f hw/ide/core.c 
    Kevin Wolf <kwolf@redhat.com> (odd fixer:IDE,commit_signer:6/27=22%)
    Stefan Hajnoczi <stefanha@redhat.com> (odd fixer:IDE,commit_signer:18/27=67%)
    John Snow <jsnow@redhat.com> (commit_signer:13/27=48%)
    Paolo Bonzini <pbonzini@redhat.com> (commit_signer:11/27=41%)
    Fam Zheng <famz@redhat.com> (commit_signer:4/27=15%)

With the patch:

    $ scripts/get_maintainer.pl -f hw/ide/core.c 
    Kevin Wolf <kwolf@redhat.com> (odd fixer:IDE)
    Stefan Hajnoczi <stefanha@redhat.com> (odd fixer:IDE)

which behaves the same as:

    $ scripts/get_maintainer.pl -f block/qed.c
    Kevin Wolf <kwolf@redhat.com> (supporter:Block)
    Stefan Hajnoczi <stefanha@redhat.com> (supporter:Block)

Paolo