From: Marc Sune <marc.sune-kpkqNMk1I7M@public.gmane.org>
To: Thomas Monjalon
<thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] KNI: fix compilation warning 'missing-field-initializers'
Date: Wed, 22 Oct 2014 10:42:33 +0200 [thread overview]
Message-ID: <54476DF9.6060906@bisdn.de> (raw)
In-Reply-To: <2234340.4n5qb1rBlX@xps13>
The mutex needs to be initialized to RTE_SPINLOCK_INITIALIZER(0) too, or
move the initialization of the mutex to rte_kni_init().
I can prepare a second patch with one or the other option, if you want.
marc
On 22/10/14 10:37, Thomas Monjalon wrote:
> 2014-10-22 09:10, Marc Sune:
>> Fix for compilation warning 'missing-field-initializers' for some
>> GCC and clang versions introduced in commit 0c6bc8e
>>
>> Signed-off-by: Marc Sune <marc.sune-kpkqNMk1I7M@public.gmane.org>
> It's not needed to initialize all fields.
> This should be sufficient:
> +static struct rte_kni_memzone_pool kni_memzone_pool = {.initialized = 0};
>
next prev parent reply other threads:[~2014-10-22 8:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 22:51 [PATCH v4] KNI: use a memzone pool for KNI alloc/release Marc Sune
[not found] ` <1413586289-6694-1-git-send-email-marc.sune-kpkqNMk1I7M@public.gmane.org>
2014-10-21 4:57 ` Zhang, Helin
2014-10-21 8:29 ` Thomas Monjalon
2014-10-21 10:52 ` Marc Sune
[not found] ` <54463ADC.8080901-kpkqNMk1I7M@public.gmane.org>
2014-10-22 5:51 ` Liu, Jijiang
[not found] ` <1ED644BD7E0A5F4091CF203DAFB8E4CC01D8288F-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-22 7:10 ` [PATCH] KNI: fix compilation warning 'missing-field-initializers' Marc Sune
[not found] ` <1413961851-13230-1-git-send-email-marc.sune-kpkqNMk1I7M@public.gmane.org>
2014-10-22 7:14 ` Marc Sune
2014-10-22 8:11 ` Liu, Jijiang
2014-10-22 8:37 ` Thomas Monjalon
2014-10-22 8:42 ` Marc Sune [this message]
[not found] ` <54476DF9.6060906-kpkqNMk1I7M@public.gmane.org>
2014-10-22 8:50 ` Thomas Monjalon
2014-10-22 9:49 ` Marc Sune
[not found] ` <54477DBD.1090701-kpkqNMk1I7M@public.gmane.org>
2014-10-22 9:59 ` Richardson, Bruce
2014-10-22 10:00 ` Thomas Monjalon
2014-10-22 10:23 ` [PATCH v2] " Marc Sune
[not found] ` <1413973391-10272-1-git-send-email-marc.sune-kpkqNMk1I7M@public.gmane.org>
2014-10-22 10:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54476DF9.6060906@bisdn.de \
--to=marc.sune-kpkqnmk1i7m@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.